Conversation
This was referenced Mar 5, 2026
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
shikanime
requested review from
StephaneTrebel
and removed request for
StephaneTrebel
This was referenced Mar 6, 2026
shikanime
force-pushed
the
pr1968
branch
4 times, most recently
from
75d5b95 to
c4277db
Compare
Contributor
Author
|
Est-ce que c'est necessaire, je m'en souviens plus |
auto-merge was automatically disabled
March 9, 2026 16:08
Pull request was closed
This was referenced Mar 11, 2026
shikanime
force-pushed
the
pr1974
branch
2 times, most recently
from
1e8a704 to
91d5bd7
Compare
shikanime
force-pushed
the
pr1974
branch
3 times, most recently
from
373e435 to
c51c821
Compare
Running tests using vitest in the server-nestjs package seems to break module resolution because of nodenext module resolution. ``` Error: Failed to resolve entry for package "@cpn-console/shared". The package may have incorrect main/module/exports specified in its package.json. ``` Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
This was referenced Mar 12, 2026
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (71.00% Estimated after merge)
This was referenced Mar 12, 2026
StephaneTrebel
approved these changes
Mar 12, 2026
Collaborator
StephaneTrebel
left a comment
StephaneTrebel
left a comment
There was a problem hiding this comment.
LGTM, à voir ce que ça donne en aval (server, etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running tests using vitest in the server-nestjs package seems to break module resolution because of nodenext module resolution.
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr
Stack created with Sapling. Best reviewed with ReviewStack.