Conversation
This was referenced Feb 12, 2026
shikanime
force-pushed
the
pr1917
branch
3 times, most recently
from
66163ad to
7c72dfd
Compare
shikanime
force-pushed
the
pr1917
branch
2 times, most recently
from
b4add56 to
9fad1f3
Compare
shikanime
force-pushed
the
pr1917
branch
2 times, most recently
from
c918e8d to
6f07370
Compare
Contributor
|
🤖 Hey ! A preview of the application is available at : https://console-pr-1917.dso.cpin-hp.numerique-interieur.fr Please be patient, deployment may take a few minutes. |
shikanime
force-pushed
the
pr1917
branch
2 times, most recently
from
f367d16 to
107a32a
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
shikanime
force-pushed
the
pr1917
branch
2 times, most recently
from
c4f02ed to
71561e3
Compare
shikanime
force-pushed
the
pr1905
branch
2 times, most recently
from
5d97d67 to
e35f8c9
Compare
Current implementation assume that the API return the whole list, which is not truth. Related: #1916 Co-authored-by: William Phetsinorath <william.phetsinorath@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Co-authered-by: William Phetsinorath <william.phetsinorath@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Co-authered-by: William Phetsinorath <william.phetsinorath@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Co-authored-by: William Phetsinorath <william.phetsinorath@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
|
0 New Issues
0 Fixed Issues
0 Accepted Issues| expect(result.store).toEqual(mockStore) | ||
| }) | ||
|
|
||
| it('handles members with roles correctly', () => { |
Collaborator
There was a problem hiding this comment.
suggestion(non-blocker):
Suggested change
| it('handles members with roles correctly', () => { | |
| it('preserves project roles and members when creating hook', () => { |
correctly n'a pas de sens intrinsèque.
Le test est justement là pour expliciter ce que correctly veut dire, dans ce contexte précis 😉
StephaneTrebel
approved these changes
Feb 24, 2026
shikanime
force-pushed
the
pr1905
branch
2 times, most recently
from
59a6bd4 to
b35f616
Compare
shikanime
force-pushed
the
pr1905
branch
6 times, most recently
from
ce0cb7b to
511439f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: William Phetsinorath william.phetsinorath@shikanime.studio
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr
Stack created with Sapling. Best reviewed with ReviewStack.