Skip to content

feat(sonarqube): make admin group path configurable though console#1905

Open
shikanime wants to merge 1 commit intomainfrom
pr1905
Open

feat(sonarqube): make admin group path configurable though console#1905
shikanime wants to merge 1 commit intomainfrom
pr1905

Conversation

@shikanime
Copy link
Contributor

@shikanime shikanime commented Feb 6, 2026

Co-authered-by: William Phetsinorath william.phetsinorath@shikanime.studio
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🤖 Hey !

The @cpn-console/hooks (v4.0.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🤖 Hey !

The @cpn-console/keycloak-plugin (v2.1.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🤖 Hey !

The @cpn-console/sonarqube-plugin (v2.0.5) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🤖 Hey !

The @cpn-console/shared (v1.3.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🤖 Hey !

The @cpn-console/gitlab-plugin (v3.3.1) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@shikanime shikanime changed the title feat(sonarrqube): make admin group path configurable though console feat(sonarqube): make admin group path configurable though console Feb 6, 2026
@shikanime shikanime marked this pull request as draft February 6, 2026 15:28
@github-actions github-actions bot added the built label Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime marked this pull request as ready for review February 20, 2026 09:27
@shikanime shikanime self-assigned this Feb 20, 2026
@shikanime shikanime added the enhancement New feature or request label Feb 20, 2026
@shikanime shikanime added this to the Gestion fins des droits milestone Feb 20, 2026
@shikanime shikanime added the preview Deploy preview app with Argo-cd label Feb 20, 2026
@github-actions
Copy link
Contributor

🤖 Hey !

A preview of the application is available at : https://console-pr-1905.dso.cpin-hp.numerique-interieur.fr

Please be patient, deployment may take a few minutes.

StephaneTrebel
StephaneTrebel previously approved these changes Feb 23, 2026
Copy link
Collaborator

@StephaneTrebel StephaneTrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authered-by: William Phetsinorath <william.phetsinorath@shikanime.studio>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
@cloud-pi-native-sonarqube
Copy link

Copy link
Collaborator

@StephaneTrebel StephaneTrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Une chtite question, mais c'est mineur. LGTM

}

async function setAdminPermisions() {
async function setTemplateGroupPermissions(groupName: string, permissions: readonly string[], templateName: string) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: permissions c'est une permission au sens défini ici ?

Ça me paraît louche que ce soit "simplement" un string[] à l'entrée comme ça 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui tout a fait, c'est une fonction plus generique

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

built enhancement New feature or request preview Deploy preview app with Argo-cd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants