Conversation
|
🤖 Hey ! The @cpn-console/hooks (v4.0.0) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The @cpn-console/keycloak-plugin (v2.1.0) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The @cpn-console/sonarqube-plugin (v2.0.5) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The @cpn-console/shared (v1.3.0) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The @cpn-console/gitlab-plugin (v3.3.1) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
2f6f9b7 to
a123c81
Compare
5468a36 to
f12d4db
Compare
|
🤖 Hey ! A preview of the application is available at : https://console-pr-1905.dso.cpin-hp.numerique-interieur.fr Please be patient, deployment may take a few minutes. |
6ec807a to
7648500
Compare
3eb7dd8 to
7d7b031
Compare
6be8c87 to
e0f2629
Compare
a2d6c6c to
d532489
Compare
Co-authered-by: William Phetsinorath <william.phetsinorath@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
|
StephaneTrebel
left a comment
There was a problem hiding this comment.
Une chtite question, mais c'est mineur. LGTM
| } | ||
|
|
||
| async function setAdminPermisions() { | ||
| async function setTemplateGroupPermissions(groupName: string, permissions: readonly string[], templateName: string) { |
There was a problem hiding this comment.
question: permissions c'est une permission au sens défini ici ?
Ça me paraît louche que ce soit "simplement" un string[] à l'entrée comme ça 🤔
There was a problem hiding this comment.
Oui tout a fait, c'est une fonction plus generique

0 New Issues
2 Fixed Issues
0 Accepted Issues
No data about coverage (71.10% Estimated after merge)
Co-authered-by: William Phetsinorath william.phetsinorath@shikanime.studio
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr