CIP-104: Daml for rewards accounting V2 and sv-app UI fixes

[dfordivam]

Fixes: https://github.com/hyperledger-labs/splice/issues/4804

This is the base branch for all the work to be done as part of https://github.com/hyperledger-labs/splice/issues/4802

This branch consists of

• DAML changes

  • https://github.com/hyperledger-labs/splice/pull/3964
  • Add trafficPrice, rewardConfig to SummarizingMiningRound
  • Add appRewardCouponThreshold : Decimal to RewardConfig
  • Compute featured app rewards from activity totals in runNextIssuance and runNextIssuanceD

• Version bumps, + dars

• SV UI fixes to allow 'rewardConfig' change voting

• Fixes done as part of Traffic-Based App Rewards: Fix hashing of batches #5193

Pull Request Checklist

Cluster Testing

• If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
• If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
• If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

• Include any change that might be observable by our partners or affect their deployment in the release notes.
• Specify fixed issues with Fixes #n, and mention issues worked on using #n
• Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

• Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

[dfordivam]

@meiersi-da @adetokunbo Please note this branch( dfordivam/cip-104-sv-app-rewards) is now ready for use as a base for the subsequent work requiring daml changes. (cc @rautenrieth-da )

The SV-app UI support for doing the config change submission is minimal, ie no dropdowns for enum fields. This matched the existing UI for other fields in the config.
I tried but not could not confirm if the SV UI is able to do the rewardConfig fields modifications via vote, due to unrelated failures (CORS issues, breaking governance UI). Though I could submit a vote for doing the change via SV1, which at least shows that ledger accepted the vote request. If the user makes a typo, the submission of vote request would fail.

The static tests are failing due to headerCheck. I also posted in slack that this cannot be fixed without also affecting splice-api-featured-app-v1 package. So I will keep this as it is for now. (Edit: fixed via c9c8822)

Finally there isn't much to review here, and I will keep this PR open in draft mode open for running the CI whenever I do a rebase.

[meiersi-da]

The static tests are failing due to headerCheck. I also posted in slack that this cannot be fixed without also affecting splice-api-featured-app-v1 package. So I will keep this as it is for now. (Edit: fixed via c9c8822)

Feel free to change the static header check to ignore the splice-api packages, if the fix for this issue by @isegall-da is not merged in on main for your PR:

• https://github.com/hyperledger-labs/splice/issues/4849

[meiersi-da]

Thanks a lot. Looks good.

I can't approve as your base branch is set to main. We don't want to merge this to main. If you set your base branch to the feature banch, and make this a normal PR against that feature branch I can approve, and you'll still get a CI run; and you can then merge using squash merge to get the one CI checked commit.

[dfordivam]

I reordered the commits, and squashed the multiple .lock, darResouces updates. Confirmed that no diffs were introduced.

If you set your base branch to the feature banch, and make this a normal PR against that feature branch I can approve, and you'll still get a CI run; and you can then merge using squash merge to get the one CI checked commit.

At the moment I feel that keeping the entire commit history intact is better, once Tim's branch is merged on main, I will again need to do version bumps, and as discussed today more daml changes would need to happen for the reward-sharing work.

[meiersi-da]

I reordered the commits, and squashed the multiple .lock, darResouces updates. Confirmed that no diffs were introduced.

If you set your base branch to the feature banch, and make this a normal PR against that feature branch I can approve, and you'll still get a CI run; and you can then merge using squash merge to get the one CI checked commit.

At the moment I feel that keeping the entire commit history intact is better, once Tim's branch is merged on main, I will again need to do version bumps, and as discussed today more daml changes would need to happen for the reward-sharing work.

Fine with me 👍

[dfordivam]

Summary of rebase

• Squashed five commits from Simon (25d1e1f, 247fa31, 275c3b5, 0a6d819, 3ee2113) into d9b7ede. The squashed commit combines the add + remove of the reward-sharing interface code making the rebase easier. And it no longer modifies build.sbt.
• Add new commit d192a64 to Replace deprecated submitMulti with submit
• Removed following commits as they are no longer needed
  • aee423b Fix build.sbt
  • 6142aa1 Ignore FeaturedAppRightV1 for headerCheck
  • f6a6841 Add new versions to DarResources
• Squashed 0d8c167 in ee61515 to fix build

[dfordivam]

@meiersi-da This is now ready for review, it has all the daml changes. I have added the following commits

553a8e3 * Fix link to "SV Longterm schedule"
b4d8b10 * Add latest daml versions
f75e55c * Rename migration
822d0b9 * Traffic-Based App Rewards: Fix hashing of batches (#5193)

And dropped this commit, as we don't need it (and it was later replaced/fixed in another branch)
e6e4763 SvDsoStore: Ingest RewardCouponV2, CalculateRewardsV2, ProcessRewardsV2

[dfordivam]

Release notes

[meiersi-da]

Very nice! Thank you for getting us here @dfordivam !