DO NOT MERGE: Daml code for implementing traffic-based app rewards by meiersi-da · Pull Request #3964 · canton-network/splice

meiersi-da · 2026-02-16T09:28:36Z

@moritzkiefer-da : the code is now fully finished. If you find some time next week to do a final review, then that would be great.

Added "DO NOT MERGE" to title, as we want to merge this into the right feature branch once the implementation has progressed far enough.

Pull Request Checklist

Cluster Testing

If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

Include any change that might be observable by our partners or affect their deployment in the release notes.
Specify fixed issues with Fixes #n, and mention issues worked on using #n
Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

meiersi-da

@moritzkiefer-da : I have a sketch of what I believe are all the choices and templates to make the switch to traffic-based app rewards possible at the Daml level. Some simple work is delayed via FIXMEs in the code.

Could I ask you for a review to check alignment, in particular:

highlight implementation choices that you disagree with / consider fishy
highlight aspects / workflows that are missing or that you are not sure how they'll work

You don't have to work too hard on the latter part. I expect that we also find them as part of writing up and reviewing the full design.

moritzkiefer-da

Nice thanks!

moritzkiefer-da · 2026-02-27T15:47:41Z

@moritzkiefer-da : the code is now fully finished. If you find some time next week to do a final review, then that would be great.

will get to it on Monday

moritzkiefer-da

Great work thanks!

[static]

bame-da · 2026-03-04T07:45:52Z

+      extraArgs : ExtraArgs
+        -- ^ Extra arguments for extensibility. Set to empty, unless needed for specific implementations.
+    observer map (.beneficiary) newBeneficiaries
+    controller (view this).beneficiary


This makes RewardCoupons transferrable. It looks like a classic bearer instrument redeemable with the dso. I worry that this could be an issue for some stakeholders.

It will be added in a separate PR Signed-off-by: Simon Meier <simon@digitalasset.com>

Signed-off-by: Simon Meier <simon@digitalasset.com>

dfordivam · 2026-04-10T09:04:38Z

    round : Round
    amuletPrice : Decimal
    issuanceConfig : IssuanceConfig
    tickDuration : RelTime


@meiersi-da I believe we want to pass the trafficPrice and rewardConfig to SummarizingMiningRound? I guess that was the intention of adding it to OpenMiningRound; to have this data available in SummarizingMiningRoundTrigger?

What would you expect that trigger to do with this information? Right now the code is organized such that the Calculate/ProcessRewardsV2 workflow runs to the side of the SummarizingRound workflow.

In SummarizingMiningRoundTrigger I need to determine the rewardConfig.mintingVersion for the round, and the CC totals for featuredAppRewardCoupons based on total traffic for round. I guess I can query the corresponding OpenMiningRound to fetch both of this info. But since the OpenMiningRound has been archived, it wont be in ACS, so fetch from update_history will be required.

Ah I see. I now realize my mistake. I was thinking of the IssuingMiningRound. Your request makes sense. Please add the fields to copy the info from the OpenMiningRound.

Another related concern is that the test code is still based on AppRewardCoupon count. Specifically

runNextIssuance token-standard/splice-token-standard-test/daml/Splice/Testing/Registries/AmuletRegistry.daml runNextIssuanceD daml/splice-dso-governance-test/daml/Splice/Scripts/DsoTestUtils.daml

And we even use these APIs as it is in Splice.Scripts.TestRewardAccountingV2.
Do you think we should do any modifications to these?

The scala is simply injecting the totalFeaturedAppRewardCoupons via offline calcs, so the flow is more or less identical to the existing daml testing even in the case of RewardVersion_TrafficBasedAppRewards. And as long as the totalFeaturedAppRewardCoupons is being set properly it would work fine.

We could pass in Optional Decimal to runNextIssuance and use that alongwith an assert on rewardConfig, to keep the logic in sync with the scala.

I did implement this, see PR #4724

Thanks. yes, good call.

moritzkiefer-da force-pushed the cocreature/transfer-24h branch from 80c89e5 to 824bd4d Compare February 16, 2026 12:00

meiersi-da changed the base branch from cocreature/transfer-24h to meiersi/backup/app-rewards-base-branch February 16, 2026 12:04

meiersi-da commented Feb 17, 2026

View reviewed changes

Comment thread daml/splice-amulet/daml/Splice/Amulet/RewardAccountingV2.daml Outdated

meiersi-da mentioned this pull request Feb 17, 2026

DRAFT: daml for confirmation response traffic reimbursement #3338

Closed

6 tasks

moritzkiefer-da reviewed Feb 17, 2026

View reviewed changes

meiersi-da mentioned this pull request Feb 17, 2026

WIP: poc of Daml for traffic-based rewards issuance #3528

Closed

6 tasks

meiersi-da changed the title ~~DRAFT: PoC for Daml fo traffic-based app rewards~~ DRAFT: PoC for Daml of traffic-based app rewards Feb 17, 2026

meiersi-da force-pushed the meiersi/daml/app-rewards-minting-core branch from f2474d0 to 057486f Compare February 20, 2026 17:19

meiersi-da force-pushed the meiersi/backup/app-rewards-base-branch branch from f3677b9 to f126f7b Compare February 27, 2026 07:22

meiersi-da force-pushed the meiersi/daml/app-rewards-minting-core branch 3 times, most recently from 9566611 to edc394a Compare February 27, 2026 15:37

meiersi-da commented Feb 27, 2026

View reviewed changes

Comment thread daml/splice-amulet/daml/Splice/AmuletRules.daml

meiersi-da changed the title ~~DRAFT: PoC for Daml of traffic-based app rewards~~ Daml code for implementing traffic-based app rewards Feb 27, 2026

meiersi-da changed the title ~~Daml code for implementing traffic-based app rewards~~ DO NOT MERGE: Daml code for implementing traffic-based app rewards Feb 27, 2026

meiersi-da marked this pull request as ready for review February 27, 2026 15:46

moritzkiefer-da approved these changes Mar 2, 2026

View reviewed changes

meiersi-da commented Mar 2, 2026

View reviewed changes

Comment thread daml/splice-amulet-test/daml/Splice/Scripts/TestRewardAccountingV2.daml

Implement reward accounting v2 for CIP-104

afe0825

[static]

meiersi-da force-pushed the meiersi/daml/app-rewards-minting-core branch from e43454f to afe0825 Compare March 3, 2026 06:38

bame-da reviewed Mar 4, 2026

View reviewed changes

dfordivam reviewed Mar 4, 2026

View reviewed changes

Comment thread daml/splice-amulet/daml/Splice/Amulet/RewardAccountingV2.daml Outdated

Add FIXME on rewardCouponTTL

dd1d5ad

rautenrieth-da mentioned this pull request Mar 26, 2026

Add DB versions of Splice.Amulet.CryptoHash #4662

Merged

7 tasks

meiersi-da added 3 commits March 31, 2026 09:17

Remove reward sharing v2 code [ci]

0283fd3

It will be added in a separate PR Signed-off-by: Simon Meier <simon@digitalasset.com>

Polish release notes [static]

498d806

Signed-off-by: Simon Meier <simon@digitalasset.com>

Address comment typos and left-over FIXMEs [no ci]

b37b7f3

Signed-off-by: Simon Meier <simon@digitalasset.com>

dfordivam reviewed Apr 1, 2026

View reviewed changes

Comment thread daml/splice-amulet/daml/Splice/AmuletRules.daml

dfordivam mentioned this pull request Apr 3, 2026

CIP-104: Daml for rewards accounting V2 and sv-app UI fixes #4724

Merged

7 tasks

dfordivam reviewed Apr 6, 2026

View reviewed changes

Comment thread daml/splice-amulet/daml/Splice/AmuletRules.daml

dfordivam reviewed Apr 10, 2026

View reviewed changes

Conversation

meiersi-da commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

Cluster Testing

PR Guidelines

Merge Guidelines

Uh oh!

meiersi-da left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

moritzkiefer-da left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moritzkiefer-da commented Feb 27, 2026

Uh oh!

moritzkiefer-da left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bame-da Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dfordivam Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

meiersi-da Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

dfordivam Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meiersi-da Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

dfordivam Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

dfordivam Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dfordivam Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

meiersi-da Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

meiersi-da commented Feb 16, 2026 •

edited

Loading

dfordivam Apr 10, 2026 •

edited

Loading

dfordivam Apr 13, 2026 •

edited

Loading