Skip to content

feat(examples-chat,chat): drop bubble-level GenUI skeleton #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blove merged 1 commit into from
May 12, 2026
Merged

feat(examples-chat,chat): drop bubble-level GenUI skeleton #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions libs/chat/src/lib/compositions/chat/chat.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,3 +404,19 @@ describe('ChatComponent — isGenuiTurn', () => {
expect(isGenuiTurn(null, undefined)).toBe(false);
});
});

describe('ChatComponent — no bubble-level GenUI skeleton', () => {
// Regression for the progressive-GenUI cleanup: the chat composition
// template must NOT render <chat-genui-skeleton> from within the
// assistant message bubble. The skeleton/coalescing belongs to a
// dedicated outer slot (chat-message-list / coalescer), not the bubble.
it('chat.component.ts source contains no <chat-genui-skeleton> tag', async () => {
const fs = await import('node:fs');
const path = await import('node:path');
const url = await import('node:url');
const here = path.dirname(url.fileURLToPath(import.meta.url));
const src = fs.readFileSync(path.join(here, 'chat.component.ts'), 'utf8');
expect(src.includes('chat-genui-skeleton')).toBe(false);
expect(src.includes('ChatGenuiSkeletonComponent')).toBe(false);
});
});
15 changes: 2 additions & 13 deletions libs/chat/src/lib/compositions/chat/chat.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import { ChatMessageActionsComponent } from '../../primitives/chat-message-actio
import { ChatWelcomeComponent } from '../../primitives/chat-welcome/chat-welcome.component';
import { ChatSelectComponent, type ChatSelectOption } from '../../primitives/chat-select/chat-select.component';
import { A2uiSurfaceComponent } from '../../a2ui/surface.component';
import { ChatGenuiSkeletonComponent } from '../../primitives/chat-genui-skeleton/chat-genui-skeleton.component';
import { ChatScrollBubbleComponent } from '../../primitives/chat-scroll-bubble/chat-scroll-bubble.component';
import { createContentClassifier, type ContentClassifier } from '../../streaming/content-classifier';
import { messageContent } from '../shared/message-utils';
Expand Down Expand Up @@ -59,7 +58,7 @@ export function isPinned(
ChatThreadListComponent, ChatGenerativeUiComponent,
ChatStreamingMdComponent, ChatToolCallsComponent, ChatSubagentsComponent, A2uiSurfaceComponent,
ChatMessageActionsComponent, ChatWelcomeComponent, ChatSelectComponent, ChatReasoningComponent,
ChatGenuiSkeletonComponent, ChatScrollBubbleComponent,
ChatScrollBubbleComponent,
],
changeDetection: ChangeDetectionStrategy.OnPush,
styles: [CHAT_HOST_TOKENS, `
Expand Down Expand Up @@ -155,7 +154,6 @@ export function isPinned(
@let content = messageContent(message);
@let classified = classifyMessage(content, message);
@let pending = classified.type() === 'pending';
@let genuiTurn = isGenuiTurn(message, prevMessage(i), i);
<chat-message
[role]="'assistant'"
[message]="message"
Expand All @@ -179,16 +177,7 @@ export function isPinned(
</ng-container>
</chat-tool-calls>
<chat-subagents [agent]="agent()" />
@if (genuiTurn && classified.type() !== 'a2ui' && classified.type() !== 'json-render') {
<!-- GenUI turn awaiting the rendered surface — skeleton suppresses
any streaming markdown that may flow before the classifier
resolves (e.g. raw sub-LLM JSON envelopes streaming before
emit_generated_surface prepends its A2UI sentinel prefix). -->
<chat-genui-skeleton />
} @else if (classified.type() === 'a2ui' && classified.a2uiSurfaces().size === 0 && genuiTurn) {
<!-- Surface event arrived but envelopes haven't yet parsed into surfaces. -->
<chat-genui-skeleton />
} @else if (classified.markdown(); as md) {
@if (classified.markdown(); as md) {
<chat-streaming-md [content]="md" [streaming]="agent().isLoading() && i === agent().messages().length - 1" />
}
@if (classified.spec(); as spec) {
Expand Down
Loading