feat(examples-chat,chat): drop bubble-level GenUI skeleton#254
Merged
Conversation
Remove the two @if branches in chat.component.ts that mounted <chat-genui-skeleton> from inside the assistant message bubble. The skeleton/coalescing belongs to a dedicated outer slot, not the bubble. Keep the markdown branch as the sole content path; the ChatGenuiSkeletonComponent stays exported for downstream use. Add a regression test asserting no <chat-genui-skeleton> tag or ChatGenuiSkeletonComponent import remains in the composition source.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the two bubble-level
<chat-genui-skeleton>branches from thechat composition's assistant-message template. The skeleton and any
coalescing behavior belong to a dedicated outer slot, not inside the
message bubble itself. The kept branch renders
<chat-streaming-md>for markdown content.
ChatGenuiSkeletonComponentremains exportedfrom
@ngaf/chat's public API for downstream consumers.Changes
libs/chat/src/lib/compositions/chat/chat.component.ts: collapsethe
@if/@else ifchain around the assistant bubble content tojust the
<chat-streaming-md>markdown branch; remove the now-unusedChatGenuiSkeletonComponentimport andimportsentry; drop theunused
genuiTurn@letbinding.libs/chat/src/lib/compositions/chat/chat.component.spec.ts: add aregression test asserting the composition source contains neither
the
<chat-genui-skeleton>tag nor theChatGenuiSkeletonComponentimport.
Test plan
nx test chatpassesnx build chatpassesnx lint chatpassesnpm run generate-api-docsregenerates cleanly (no public-API drift)