ci: standardize workflows and chart patterns to match org playbook#20
Merged
Conversation
- Delete build-and-push-app.yaml.inactive and VERSION file
- Fix helm push error guard: use || { echo; exit 1; } pattern
- Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 to all workflows
- Use shell-safe env: blocks for GHA expressions
- Add digest guard to release-retag sign step
- Fix deployment.yaml affinity check: use ne (toJson) instead of if
- Add x-release-please-version annotation to Chart.yaml version line
- Fix Dockerfile comments (## -> #)
- Update AGENTS.md to reflect manifest-based version tracking
- Reduce verbose block comments across workflows
Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes workflows, Helm charts, and supporting files to match
bcit-tlu/qcon-apipatterns:build-and-push-app.yaml.inactive(unused) andVERSIONfile (version tracked via manifest)|| { echo; exit 1; }), shell-safeenv:blocks for GHA expressions, reduced verbose block commentsFORCE_JAVASCRIPT_ACTIONS_TO_NODE24, shell-safe env, dynamic chart name viayq&& steps.retag.outputs.digest != ''), shell-safe env vars, array-based tag construction, reduced commentsFORCE_JAVASCRIPT_ACTIONS_TO_NODE24, reduced comment verbosityFORCE_JAVASCRIPT_ACTIONS_TO_NODE24, concise failure message matching qcon-api# x-release-please-versionannotation toversion:line{{- if $aff }}to{{- if ne (toJson $aff) "{}" }}for proper empty-map detection##→#for comments.release-please-manifest.jsonand Chart.yaml annotations instead of deleted VERSION file; added helm lint/validate commandsReview & Testing Checklist for Human
helm lint charts/andhelm template test charts/ | kubeconform ...pass (validated locally ✓)release-retag.yamldigest guard ensures signing is skipped when retag fails (no empty-digest cosign calls)Notes
All workflows now have
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true,actions/checkout@v6, and use shell-safeenv:blocks for GHA context expressions. No changes to app code, Docusaurus config, build logic, CI triggers, or deployment behavior.Link to Devin session: https://app.devin.ai/sessions/b22ab1e0b73e4c509de302626f4a5af5
Requested by: @kphunter