Closed
Conversation
Contributor
|
Nice. |
Closed
Contributor
Contributor
|
@zackehh could you please rebase this PR on top of develop (which now contains a fix for erlang:now/0 but still does't have fix for erl_exit) ? |
Author
|
@lemenkov sure thing, I'll close this & open up a new one shortly. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few issues when compiling against OTP 18.3. I have provided this PR to demonstrate fixes for those that need them (and will add more as needed).
I'm not familiar enough with C preprocessor voodoo to figure out how to make the switch from
erl_exittoerts_exitbackwards compatible, so if anyone has any tips that would be great (having said that, OTP itself wasn't backwards compatible).I actually think this project should just use it's own exit functions instead of relying on those in OTP because they're not actually meant to be public: https://github.com/erlang/otp/blob/maint/erts/emulator/drivers/common/inet_drv.c#L1576. It was changed without PR and broken in a minor version.
This will correct #51 and #53.