Closed
Conversation
|
FWIW #58 covers this in a slightly more elegant way |
Author
|
@zackehh thanks for the reference. I hadn't thought of I was also unaware of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing out a few things with this library and noticed that it was failing to compile under Erlang/OTP 18+ because of the usage of
erlang:now(). Not sure if this is the right move for the overall project, but if other people want to build this on more recent versions of erlang they might want to make a similar patch.The deprecation information is documented in the erts docs for why they deprecated this.