Skip to content

Build on ubuntu-22.04 and fix the sagemaker ui poststart up patch #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sachinh-amazon wants to merge 1 commit into
base: 1.0
Choose a base branch
from
Open

Build on ubuntu-22.04 and fix the sagemaker ui poststart up patch #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-targets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
jobs:
build:
name: Build Code Editor Targets
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
build-target: [code-editor-server, code-editor-sagemaker-server, code-editor-web-embedded, code-editor-web-embedded-with-terminal]
Expand Down
13 changes: 10 additions & 3 deletions patches/sagemaker/sagemaker-ui-post-startup.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Index: code-editor-src/src/vs/server/node/webClientServer.ts
if (pathname.startsWith(WEB_EXTENSION_PATH) && pathname.charCodeAt(WEB_EXTENSION_PATH.length) === CharCode.Slash) {
// extension resource support
return this._handleWebExtensionResource(req, res, pathname.substring(WEB_EXTENSION_PATH.length));
@@ -571,6 +580,41 @@ export class WebClientServer {
@@ -571,6 +580,48 @@ export class WebClientServer {
serveError(req, res, 500, error.message)
}
}
Expand All @@ -60,8 +60,15 @@ Index: code-editor-src/src/vs/server/node/webClientServer.ts
+ //If exists, it will start the execution and add the execution logs in logFile.
+ try {
+ if (fs.existsSync(postStartupScriptPath)) {
+ // Adding 0o755 to make script file executable
+ fs.chmodSync(postStartupScriptPath, 0o755);
+ const stats = fs.statSync(postStartupScriptPath);
+ // Check if file has execute permission for owner, group, or others
+ // parseInt('111', 8) = 73 (octal 111 = --x--x--x execute bits)
+ // Bitwise AND checks if any execute bits are set
+ const isExecutable = (stats.mode & parseInt('111', 8)) !== 0;
+ if (!isExecutable) {
+ // Adding 0o755 to make script file executable
+ fs.chmodSync(postStartupScriptPath, 0o755);
+ }
+
+ const subprocess = spawn('bash', [`${postStartupScriptPath}`], { cwd: '/' });
+ subprocess.stdout.pipe(logStream);
Expand Down