Build on ubuntu-22.04 and fix the sagemaker ui poststart up patch #120
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
D383171768 in Taskei, P369003901 in T-corp
Description of Changes
This PR makes the following two changes:
ubuntu-latesttranslates to ubuntu24 and it has GLIBC version 2.38. Because of this mismatch in GLIBC version,@parcel/watcherfails to load and crashes Code Editor. Building onubuntu22.04fixes this issue.chmodSynccommand in_handlePostStartupScriptInvocationfails withEPERM Insufficient permissions. The script/etc/sagemaker-ui/sagemaker_ui_post_startup.shdoes not require updating permissions as it already is an executable. The updated patch first checks if the script is executable or not and only executes thechmodcommand if the script is not an executable.Testing
The build works as expected. Ran the build on my fork: https://github.com/sachinh-amazon/code-editor/actions/runs/21401288330
Screenshots/Videos
Deployed on my AWS account and verified that Git-based workspaces open, which were throwing an error before.
Screen.Recording.2026-01-27.at.16.27.25.mov
Additional Notes
Backporting
Yes, this change will also be merged in the
mainbranch.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.