Skip to content

[feat][broker] PIP-398: Subscription replication on the namespace and topic levels#29

Merged
nodece merged 1 commit into
ascentstream:branch-as-2.10from
nodece:replicateSubscriptionsEnabled
Dec 27, 2024
Merged

[feat][broker] PIP-398: Subscription replication on the namespace and topic levels#29
nodece merged 1 commit into
ascentstream:branch-as-2.10from
nodece:replicateSubscriptionsEnabled

Conversation

@nodece

@nodece nodece commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

PIP: apache#23770

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@nodece nodece force-pushed the replicateSubscriptionsEnabled branch 2 times, most recently from 84f3b86 to b1b237c Compare December 18, 2024 09:16
@nodece nodece changed the title feat: add replicateSubscriptionsEnabled for namespace and topic [feat][broker] Add replicateSubscriptionsEnabled for namespace and topic Dec 18, 2024
@nodece nodece force-pushed the replicateSubscriptionsEnabled branch from b1b237c to 43411ba Compare December 19, 2024 04:00
@nodece nodece force-pushed the replicateSubscriptionsEnabled branch 6 times, most recently from ab1e683 to e85e6ad Compare December 25, 2024 05:39

@dao-jun dao-jun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a minor comment

Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java Outdated
@nodece nodece changed the title [feat][broker] Add replicateSubscriptionsEnabled for namespace and topic [feat][broker] PIP-398: Subscription replication on the namespace and topic levels Dec 25, 2024
@nodece nodece force-pushed the replicateSubscriptionsEnabled branch from 298982a to a09edda Compare December 25, 2024 09:39
@nodece

nodece commented Dec 25, 2024

Copy link
Copy Markdown
Collaborator Author

/pulsarbot rerun-failure-checks

… topic levels

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece force-pushed the replicateSubscriptionsEnabled branch from ecf5520 to e62d12b Compare December 26, 2024 13:44
@nodece nodece merged commit 953a538 into ascentstream:branch-as-2.10 Dec 27, 2024
@nodece nodece deleted the replicateSubscriptionsEnabled branch December 27, 2024 03:26
nodece added a commit that referenced this pull request Jan 13, 2025
… topic levels (#29)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece added a commit that referenced this pull request Feb 13, 2025
… topic levels (#29)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece added a commit that referenced this pull request Feb 17, 2025
… topic levels (#29)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece added a commit that referenced this pull request Mar 24, 2026
… topic levels (#29)

# Conflicts:
#	pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/TopicPolicies.java
#	pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicPoliciesImpl.java
#	pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopicPolicies.java
#	pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/HierarchyTopicPolicies.java
#	pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicPolicies.java
nodece added a commit that referenced this pull request Mar 27, 2026
… topic levels (#29)

# Conflicts:
#	pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/TopicPolicies.java
#	pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicPoliciesImpl.java
#	pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopicPolicies.java
#	pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/HierarchyTopicPolicies.java
#	pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicPolicies.java
nodece added a commit that referenced this pull request Mar 27, 2026
… topic levels (#29)

# Conflicts:
#	pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/TopicPolicies.java
#	pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicPoliciesImpl.java
#	pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopicPolicies.java
#	pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/HierarchyTopicPolicies.java
#	pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicPolicies.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants