Skip to content

[improve][broker] Enhance compatibility with consumer replicate subscription state#33

Merged
nodece merged 1 commit into
ascentstream:branch-as-3.0from
nodece:enhance-consumer-replicate-subscription
Feb 8, 2025
Merged

[improve][broker] Enhance compatibility with consumer replicate subscription state#33
nodece merged 1 commit into
ascentstream:branch-as-3.0from
nodece:enhance-consumer-replicate-subscription

Conversation

@nodece

@nodece nodece commented Jan 24, 2025

Copy link
Copy Markdown
Collaborator

Motivation:

  • Previous Behavior: Replication subscription snapshot started if the consumer's replication subscription state was true.
  • Issue: With [feat][broker] PIP-398: Subscription replication on the namespace and topic levels #29, the replication subscription stops if the consumer's replication state is false, which breaks the previous rule.
  • Goal: Enhance compatibility by ensuring that the broker can still apply replication configuration based on topic or namespace-level settings when the consumer's replication state is false.

This pull request reverts the changes introduced in PR #29 that altered the public API.

Modifications:

  1. Topic-Level Configuration:

    • When the consumer's replication subscription state is false, but a topic-level setting is present and true, the broker will use that topic-level configuration.
  2. Namespace-Level Configuration:

    • If the consumer’s replication subscription state is false and there is no topic-level setting, but the namespace-level setting is present and true, the broker will apply the namespace-level configuration.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

…ription state

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece merged commit d865d56 into ascentstream:branch-as-3.0 Feb 8, 2025
nodece added a commit that referenced this pull request Feb 8, 2025
…ription state (#33)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece added a commit that referenced this pull request Feb 13, 2025
…ription state (#33)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece added a commit that referenced this pull request Feb 17, 2025
…ription state (#33)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants