Skip to content

fix(js): prevent double free on Buffer by passing a BufferSlice #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barjin merged 1 commit into from
Jan 29, 2026
Merged

fix(js): prevent double free on Buffer by passing a BufferSlice #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions impit-node/src/response.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use impit::utils::{decode, ContentType};
use napi::bindgen_prelude::JsObjectValue;
use napi::{
bindgen_prelude::{
Buffer, FromNapiValue, Function, Object, ReadableStream, Result, This, ToNapiValue,
BufferSlice, FromNapiValue, Function, Object, ReadableStream, Result, This, ToNapiValue,
},
sys, Env, JsValue, Unknown,
};
Expand Down Expand Up @@ -178,14 +178,14 @@ impl<'env> ImpitResponse {

/// @ignore
#[napi(ts_return_type = "string")]
pub fn decode_buffer(&self, buffer: Buffer) -> Result<String> {
pub fn decode_buffer(&self, buffer: BufferSlice) -> Result<String> {
let encoding = self
.headers
.get("content-type")
.and_then(|content_type| ContentType::from(content_type).ok());

let string = decode(
buffer.to_vec().as_slice(),
&buffer,
match encoding {
Some(encoding) => encoding.into(),
None => None,
Expand Down