fix(js): prevent double free on Buffer by passing a BufferSlice
#369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical double-free issue in the Node.js bindings under high-concurrency conditions by changing the decode_buffer function to accept a BufferSlice instead of an owned Buffer.
Changes:
- Changed parameter type from
BuffertoBufferSliceindecode_buffermethod - Updated the import to use
BufferSliceinstead ofBuffer - Simplified buffer usage from
buffer.to_vec().as_slice()to&buffer(more efficient as it avoids copying)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a non-async function,
decode_bufferdoesn't require owning theBufferand can do with only aBufferSlice. This takes the cleanup responsibility fromnapi-rsand should prevent the double free scenarios, as theBufferis now Node runtime-managed.Closes #368