Skip to content

fix: prevent EnforcerServer crash on duplicate casbin_rule insert #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tispratik wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

fix: prevent EnforcerServer crash on duplicate casbin_rule insert #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/casbin/persist/ecto_adapter.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,11 @@ defmodule Casbin.Persist.EctoAdapter do
repo = Casbin.Persist.EctoAdapter.get_repo(adapter)
changeset = CasbinRule.create_changeset(policy)

case repo.insert(changeset) do
# on_conflict: :nothing prevents Ecto.ConstraintError when a duplicate rule is
# inserted concurrently (e.g., two nodes racing, or memory/DB state diverging after
# an EnforcerServer restart). Without this, the bare insert raises and crashes the
# EnforcerServer GenServer — a critical process that takes time to restart.
case repo.insert(changeset, on_conflict: :nothing) do
{:ok, _casbin} -> {:ok, adapter}
{:error, changeset} -> {:error, changeset.errors}
end
Expand Down Expand Up @@ -375,7 +379,9 @@ defmodule Casbin.Persist.EctoAdapter do
defp insert_policy(repo, adapter, policy) do
changeset = CasbinRule.create_changeset(policy)

case repo.insert(changeset) do
# on_conflict: :nothing — same rationale as add_policy/2: save_policies/2
# truncates then re-inserts all rules; a race or restart can cause duplicates.
case repo.insert(changeset, on_conflict: :nothing) do
{:ok, _casbin} -> adapter
{:error, changeset} -> {:error, changeset.errors}
end
Expand Down