fix: prevent EnforcerServer crash on duplicate casbin_rule insert#64
Open
tispratik wants to merge 1 commit intoapache:masterfrom
Open
fix: prevent EnforcerServer crash on duplicate casbin_rule insert#64tispratik wants to merge 1 commit intoapache:masterfrom
tispratik wants to merge 1 commit intoapache:masterfrom
Conversation
The casbin_rule table has a unique index casbin_rule_content_unique on
(ptype, v0..v6) NULLS NOT DISTINCT. A bare repo.insert raises
Ecto.ConstraintError when a duplicate rule is inserted — e.g. two nodes
racing after an EnforcerServer restart, or in-memory and DB state
diverging. That exception propagates out of handle_call and crashes the
EnforcerServer GenServer, a critical process that is slow to recover.
Patched add_policy/2 and insert_policy/3 (used by save_policies/2) to
use on_conflict: :nothing, which silently skips the duplicate and returns
{:ok, struct}. No data is lost — the rule already exists in the DB.
Fixes Sentry issue BACKEND-2H2.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The casbin_rule table has a unique index casbin_rule_content_unique on (ptype, v0..v6) NULLS NOT DISTINCT. A bare repo.insert raises Ecto.ConstraintError when a duplicate rule is inserted — e.g. two nodes racing after an EnforcerServer restart, or in-memory and DB state diverging. That exception propagates out of handle_call and crashes the EnforcerServer GenServer, a critical process that is slow to recover.
Patched add_policy/2 and insert_policy/3 (used by save_policies/2) to use on_conflict: :nothing, which silently skips the duplicate and returns {:ok, struct}. No data is lost — the rule already exists in the DB.