Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/agent/preview.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,15 @@ func (a *Agent) whyExcluded(d model.Diff) ExcludeReason {
return ExcludeUserRule
}

if f != nil && f.HasInclude() && f.IsUserIncluded(path) {
return ExcludeNone
}

ext := a.extFromPath(path)
if ext != "" && !allowedext.IsAllowedExt(ext) {
return ExcludeExtension
}

if f != nil && f.HasInclude() && f.IsUserIncluded(path) {
return ExcludeNone
}

if allowedext.IsExcludedPath(path) {
return ExcludeDefaultPath
}
Expand Down
9 changes: 4 additions & 5 deletions internal/agent/preview_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ func TestWhyExcluded_DefaultPathFilter(t *testing.T) {
func TestWhyExcluded_UserIncludePattern(t *testing.T) {
agent := New(Args{
FileFilter: &rules.FileFilter{
Include: []string{"src/**/*.go", "pkg/**/*.go"},
Include: []string{"src/**/*.go", "pkg/**/*.go", "**/*.supportedext"},
},
})

Expand Down Expand Up @@ -260,13 +260,12 @@ func TestWhyExcluded_UserIncludePattern(t *testing.T) {
},
expected: ExcludeNone,
},
// --- Extension filter still takes precedence over include logic ---
{
name: "unsupported extension excluded before include check",
name: "include check overrides extension exclusion",
diff: model.Diff{
NewPath: "docs/readme.md",
NewPath: "internal/test.supportedext",
},
expected: ExcludeExtension,
expected: ExcludeNone,
},
{
name: "unsupported extension even if path looks like include dir",
Expand Down