Skip to content

fix(agent): user includes should have higher priority than system sup…#51

Open
dangrie158 wants to merge 1 commit into
alibaba:mainfrom
dangrie158:fix/user-includes-priority
Open

fix(agent): user includes should have higher priority than system sup…#51
dangrie158 wants to merge 1 commit into
alibaba:mainfrom
dangrie158:fix/user-includes-priority

Conversation

@dangrie158
Copy link
Copy Markdown

@dangrie158 dangrie158 commented Jun 5, 2026

Description

This PR simply allows the user to override the exclude list of allows extensions by explicitly including files in the rules set.

Before this change it was not possible to have e.g.:

{
    "include": ["*.po", "*.xlf"]
}

in your rules.json file and have it work because the files would be excluded before the include rules are tested.

This feature was documented and tested for, but I do not think this is expected an beheviour, however I am open to be convinced otherwise :)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring (no functional changes)
  • Documentation update
  • CI / Build / Tooling

How Has This Been Tested?

  • make test passes locally
  • Manual testing (describe below)

Tested

Checklist

  • My code follows the project's coding style (go fmt, go vet)
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly (if applicable)
  • I have signed the CLA

Related Issues

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 5, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants