fix(agent): user includes should have higher priority than system sup…#51
Open
dangrie158 wants to merge 1 commit into
Open
fix(agent): user includes should have higher priority than system sup…#51dangrie158 wants to merge 1 commit into
dangrie158 wants to merge 1 commit into
Conversation
…ported extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simply allows the user to override the exclude list of allows extensions by explicitly including files in the rules set.
Before this change it was not possible to have e.g.:
{ "include": ["*.po", "*.xlf"] }in your rules.json file and have it work because the files would be excluded before the
includerules are tested.This feature was documented and tested for, but I do not think this is expected an beheviour, however I am open to be convinced otherwise :)
Type of Change
How Has This Been Tested?
make testpasses locallyTested
Checklist
go fmt,go vet)Related Issues