FEATURE: Can edit category/host relationships for embedding#10
Open
everettbu wants to merge 1 commit into
Open
FEATURE: Can edit category/host relationships for embedding#10everettbu wants to merge 1 commit into
everettbu wants to merge 1 commit into
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+24
to
+25
| records.each do |h| | ||
| execute "INSERT INTO embeddable_hosts (host, category_id, created_at, updated_at) VALUES ('#{h}', #{category_id}, CURRENT_TIMESTAMP, CURRENT_TIMESTAMP)" |
There was a problem hiding this comment.
This SQL query is vulnerable to injection attacks because it directly interpolates user-provided values into the query string. Consider using parameterized queries instead:
execute "INSERT INTO embeddable_hosts (host, category_id, created_at, updated_at) VALUES (?, ?, CURRENT_TIMESTAMP, CURRENT_TIMESTAMP)", h, category_idThis approach properly sanitizes the inputs and prevents potential SQL injection vulnerabilities.
Suggested change
| records.each do |h| | |
| execute "INSERT INTO embeddable_hosts (host, category_id, created_at, updated_at) VALUES ('#{h}', #{category_id}, CURRENT_TIMESTAMP, CURRENT_TIMESTAMP)" | |
| records.each do |h| | |
| execute "INSERT INTO embeddable_hosts (host, category_id, created_at, updated_at) VALUES (?, ?, CURRENT_TIMESTAMP, CURRENT_TIMESTAMP)", h, category_id |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Comment on lines
+1
to
4
| Fabricator(:embeddable_host) do | ||
| host "eviltrout.com" | ||
| category | ||
| end |
There was a problem hiding this comment.
It appears that the contents of spec/fabricators/category_fabricator.rb and spec/fabricators/embeddable_host_fabricator.rb have been swapped. This file should contain the Category fabricators, while the EmbeddableHost fabricator should be in the other file. This swap needs to be corrected to maintain proper organization of the test fixtures.
Suggested change
| Fabricator(:embeddable_host) do | |
| host "eviltrout.com" | |
| category | |
| end | |
| Fabricator(:category) do | |
| name { sequence(:name) { |i| "Amazing Category #{i}" } } | |
| user | |
| end | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
This pull request has been automatically marked as stale because it has been open for 60 days with no activity. To keep it open, remove the stale tag, push code, or add a comment. Otherwise, it will be closed in 14 days. |
mfeuerstein
reviewed
Apr 10, 2026
mfeuerstein
left a comment
mfeuerstein
left a comment
There was a problem hiding this comment.
PR Review — approved
Reviewed 30 files. 0 high-severity issues found. Verdict: approved.
app/assets/javascripts/admin/templates/customize.hbs (low)
- Reviewed app/assets/javascripts/admin/templates/customize.hbs — looks good
app/assets/javascripts/admin/templates/embedding.hbs (low)
- Reviewed app/assets/javascripts/admin/templates/embedding.hbs — looks good
app/assets/javascripts/admin/adapters/embedding.js.es6 (low)
- Reviewed app/assets/javascripts/admin/adapters/embedding.js.es6 — looks good
app/assets/javascripts/admin/routes/admin-route-map.js.es6 (low)
- Reviewed app/assets/javascripts/admin/routes/admin-route-map.js.es6 — looks good
app/assets/javascripts/admin/controllers/admin-embedding.js.es6 (low)
- Reviewed app/assets/javascripts/admin/controllers/admin-embedding.js.es6 — looks good
app/assets/javascripts/admin/templates/components/embeddable-host.hbs (low)
- Reviewed app/assets/javascripts/admin/templates/components/embeddable-host.hbs — looks good
app/assets/javascripts/discourse/models/store.js.es6 (low)
- Reviewed app/assets/javascripts/discourse/models/store.js.es6 — looks good
app/controllers/admin/embeddable_hosts_controller.rb (low)
- Reviewed app/controllers/admin/embeddable_hosts_controller.rb — looks good
app/controllers/admin/embedding_controller.rb (low)
- Reviewed app/controllers/admin/embedding_controller.rb — looks good
app/assets/javascripts/admin/routes/admin-embedding.js.es6 (low)
- Reviewed app/assets/javascripts/admin/routes/admin-embedding.js.es6 — looks good
app/assets/javascripts/admin/components/embeddable-host.js.es6 (low)
- Reviewed app/assets/javascripts/admin/components/embeddable-host.js.es6 — looks good
app/assets/javascripts/discourse/adapters/rest.js.es6 (low)
- Reviewed app/assets/javascripts/discourse/adapters/rest.js.es6 — looks good
app/models/site_setting.rb (low)
- Reviewed app/models/site_setting.rb — looks good
app/models/topic_embed.rb (low)
- Reviewed app/models/topic_embed.rb — looks good
app/models/topic.rb (low)
- Reviewed app/models/topic.rb — looks good
config/locales/client.en.yml (low)
- Reviewed config/locales/client.en.yml — looks good
app/serializers/embedding_serializer.rb (low)
- Reviewed app/serializers/embedding_serializer.rb — looks good
app/controllers/embed_controller.rb (low)
- Reviewed app/controllers/embed_controller.rb — looks good
app/models/embeddable_host.rb (low)
- Reviewed app/models/embeddable_host.rb — looks good
app/serializers/embeddable_host_serializer.rb (low)
- Reviewed app/serializers/embeddable_host_serializer.rb — looks good
config/routes.rb (low)
- Reviewed config/routes.rb — looks good
spec/controllers/admin/embedding_controller_spec.rb (low)
- Reviewed spec/controllers/admin/embedding_controller_spec.rb — looks good
config/site_settings.yml (low)
- Reviewed config/site_settings.yml — looks good
config/locales/server.en.yml (low)
- Reviewed config/locales/server.en.yml — looks good
lib/topic_retriever.rb (low)
- Reviewed lib/topic_retriever.rb — looks good
spec/controllers/admin/embeddable_hosts_controller_spec.rb (low)
- Reviewed spec/controllers/admin/embeddable_hosts_controller_spec.rb — looks good
db/migrate/20150818190757_create_embeddable_hosts.rb (low)
- Reviewed db/migrate/20150818190757_create_embeddable_hosts.rb — looks good
spec/fabricators/embeddable_host_fabricator.rb (low)
- Reviewed spec/fabricators/embeddable_host_fabricator.rb — looks good
spec/fabricators/category_fabricator.rb (low)
- Reviewed spec/fabricators/category_fabricator.rb — looks good
spec/controllers/embed_controller_spec.rb (low)
- Reviewed spec/controllers/embed_controller_spec.rb — looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test 10