FEATURE: Can edit category/host relationships for embedding

[ShashankFC]

Test 10

---

Replicated from ai-code-review-evaluation/discourse-graphite#10

[graphite-app]

This query will crash if no matching category is found, as it tries to access [0]['id'] on a potentially empty result set. Needs nil checking.

result = execute("SELECT c.id FROM categories AS c...")
category_id = result.first ? result.first['id'].to_i : 0

Suggested change

	category_id = execute("SELECT c.id FROM categories AS c
	INNER JOIN site_settings AS s ON s.value = c.name
	WHERE s.name = 'embed_category'")[0]['id'].to_i
	result = execute("SELECT c.id FROM categories AS c
	INNER JOIN site_settings AS s ON s.value = c.name
	WHERE s.name = 'embed_category'")
	category_id = result.first ? result.first['id'].to_i : 0

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.

[graphite-app]

Calling sub! on self.host will raise NoMethodError if host is nil. Needs nil check before mutation.

before_validation do
  if self.host.present?
    self.host.sub!(/^https?:\/\//, '')
    self.host.sub!(/\/.*$/, '')
  end
end

Suggested change

	before_validation do
	self.host.sub!(/^https?:\/\//, '')
	self.host.sub!(/\/.*$/, '')
	end
	before_validation do
	if self.host.present?
	self.host.sub!(/^https?:\/\//, '')
	self.host.sub!(/\/.*$/, '')
	end
	end

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.

[graphite-app]

If no host is found with the given ID, host will be nil and calling save_host(nil) will cause NoMethodError when accessing nil properties.

def update
  host = EmbeddableHost.where(id: params[:id]).first
  return render_json_error('Host not found', status: 404) unless host
  save_host(host)
end

Suggested change

	host = EmbeddableHost.where(id: params[:id]).first
	save_host(host)
	host = EmbeddableHost.where(id: params[:id]).first
	return render_json_error('Host not found', status: 404) unless host
	save_host(host)

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.