Skip to content

SMS workflow reminder retry count tracking#9

Open
everettbu wants to merge 1 commit into
sms-retry-basefrom
sms-retry-enhanced
Open

SMS workflow reminder retry count tracking#9
everettbu wants to merge 1 commit into
sms-retry-basefrom
sms-retry-enhanced

Conversation

@everettbu

@everettbu everettbu commented Jul 28, 2025 •
edited
Loading

Copy link
Copy Markdown

Test 9

@CarinaWolli @Udit-takkar
fix: add retryCount to workflowReminder (#14943)
2dae0bf 
* add retry count to workflow reminder

* add logic to for retry count

---------

Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "SMS workflow reminder retry count tracking". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@lizard-boy

lizard-boy commented Jul 28, 2025

Copy link
Copy Markdown

cursor review

cursor[bot]
cursor Bot reviewed Jul 28, 2025
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugbot free trial expires on August 11, 2025
Learn more in the Cursor dashboard.

Comment thread packages/features/ee/workflows/api/scheduleSMSReminders.ts
gt: 1,
},
},
],

@cursor cursor Bot Jul 28, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SMS Deletion Logic Affects All Reminder Types

The deletion logic in scheduleSMSReminders.ts incorrectly deletes non-SMS workflow reminders (e.g., Email, WhatsApp) that have retryCount > 1. This occurs because the retryCount condition within the OR clause for deletion lacks a method: WorkflowMethods.SMS filter, causing it to apply to all reminder types instead of only SMS reminders, which is the intended scope of this function.

Locations (1)
Fix in Cursor Fix in Web

@github-actions

github-actions Bot commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions Bot added the Stale label Aug 12, 2025
This was referenced Nov 14, 2025
Open
Open
@ShashankFC ShashankFC mentioned this pull request Dec 31, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@everettbu @lizard-boy @CarinaWolli