SMS workflow reminder retry count tracking#3
Open
akshayutture-augment wants to merge 1 commit into
Open
Conversation
* add retry count to workflow reminder * add logic to for retry count --------- Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| gt: 1, | ||
| }, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
Bug: Query Over-Deletes, Removing Valid Data
The deleteMany query uses an OR condition where the second branch { retryCount: { gt: 1 } } lacks the method: WorkflowMethods.SMS filter. This causes deletion of non-SMS reminders and reminders with future scheduled dates whenever their retryCount exceeds 1, unintentionally removing valid records that were never intended to be cleaned up by this operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test 9
Replicated from ai-code-review-evaluation/cal.com-cursor#9
Note
Adds retry count tracking for SMS workflow reminders, increments on failures, and deletes reminders after multiple retries; includes DB schema/migration updates.
packages/features/ee/workflows/api/scheduleSMSReminders.ts):retryCountfor SMS reminders by selecting it and incrementing on scheduling failure or exceptions.scheduledDateor withretryCount > 1.retryCount INT DEFAULT 0toWorkflowRemindervia migration.retryCountinWorkflowReminder.Written by Cursor Bugbot for commit 2dae0bf. Configure here.