Skip to content

Fix NameError when visit_error is set in visit_uri (#851) #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohityadav8 wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Fix NameError when visit_error is set in visit_uri (#851) #852

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02ad693
Fix NameError when visit_error is set in visit_uri (#851)
mohityadav8 Mar 20, 2026
7e9f845
Update fix for visit_error logging in visit_uri
mohityadav8 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions minecode/management/commands/run_visit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ def visit_uri(resource_uri, max_uris=0, uri_counter_by_visitor=None, _visit_rout
except (ConnectionError, Timeout, Exception) as e:
# FIXME: is catching all exceptions here correct?
msg = f"Visit error for URI: {uri_to_visit}"
msg += "\n".format()
msg += "\n"
msg += get_error_message(e)
visit_errors.append(msg)
logger.error(msg)
Expand All @@ -287,8 +287,8 @@ def visit_uri(resource_uri, max_uris=0, uri_counter_by_visitor=None, _visit_rout
# Also log visit errors!!!1
if visit_error:
msg = f"Visit error for URI: {uri_to_visit}"
msg += "\n".format()
msg += get_error_message(e) # NOQA
msg += "\n"
msg += str(visit_error)
visit_errors.append(msg)
logger.error(msg)

Expand Down