Fix NameError when visit_error is set in visit_uri (#851)#852
Open
mohityadav8 wants to merge 2 commits intoaboutcode-org:mainfrom
Open
Fix NameError when visit_error is set in visit_uri (#851)#852mohityadav8 wants to merge 2 commits intoaboutcode-org:mainfrom
mohityadav8 wants to merge 2 commits intoaboutcode-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a potential
NameErrorinvisit_uri()located inminecode/management/commands/run_visit.py.Previously, the code referenced the exception variable
einside theif visit_error:block:However,
eis only defined inside theexceptblock:If
_visit_router.process(uri_to_visit)returns avisit_errorwithout raising an exception, theif visit_error:block executes whileeis undefined, causing:This PR resolves the issue by removing the reference to
eand usingvisit_errordirectly when logging the error message.This ensures the error logging works correctly even when no exception was raised.
Fixes #851.