Skip to content

[Fix] Vertex region dropdown misses us and eu multi-region endpoints #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roomote wants to merge 1 commit into from
Closed

[Fix] Vertex region dropdown misses us and eu multi-region endpoints #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/types/src/providers/vertex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,8 @@ export const VERTEX_1M_CONTEXT_MODEL_IDS = [

export const VERTEX_REGIONS = [
{ value: "global", label: "global" },
{ value: "us", label: "us" },
{ value: "eu", label: "eu" },
{ value: "us-central1", label: "us-central1" },
{ value: "us-east1", label: "us-east1" },
{ value: "us-east4", label: "us-east4" },
Expand Down
52 changes: 15 additions & 37 deletions webview-ui/src/components/settings/providers/__tests__/Vertex.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,43 +63,21 @@ describe("Vertex", () => {
expect(globalRegions).toHaveLength(1)
})

it('should contain all expected regions including "global"', () => {
// The expected list is the imported VERTEX_REGIONS itself
expect(VERTEX_REGIONS).toEqual([
{ value: "global", label: "global" },
{ value: "us-central1", label: "us-central1" },
{ value: "us-east1", label: "us-east1" },
{ value: "us-east4", label: "us-east4" },
{ value: "us-east5", label: "us-east5" },
{ value: "us-south1", label: "us-south1" },
{ value: "us-west1", label: "us-west1" },
{ value: "us-west2", label: "us-west2" },
{ value: "us-west3", label: "us-west3" },
{ value: "us-west4", label: "us-west4" },
{ value: "northamerica-northeast1", label: "northamerica-northeast1" },
{ value: "northamerica-northeast2", label: "northamerica-northeast2" },
{ value: "southamerica-east1", label: "southamerica-east1" },
{ value: "europe-west1", label: "europe-west1" },
{ value: "europe-west2", label: "europe-west2" },
{ value: "europe-west3", label: "europe-west3" },
{ value: "europe-west4", label: "europe-west4" },
{ value: "europe-west6", label: "europe-west6" },
{ value: "europe-central2", label: "europe-central2" },
{ value: "asia-east1", label: "asia-east1" },
{ value: "asia-east2", label: "asia-east2" },
{ value: "asia-northeast1", label: "asia-northeast1" },
{ value: "asia-northeast2", label: "asia-northeast2" },
{ value: "asia-northeast3", label: "asia-northeast3" },
{ value: "asia-south1", label: "asia-south1" },
{ value: "asia-south2", label: "asia-south2" },
{ value: "asia-southeast1", label: "asia-southeast1" },
{ value: "asia-southeast2", label: "asia-southeast2" },
{ value: "australia-southeast1", label: "australia-southeast1" },
{ value: "australia-southeast2", label: "australia-southeast2" },
{ value: "me-west1", label: "me-west1" },
{ value: "me-central1", label: "me-central1" },
{ value: "africa-south1", label: "africa-south1" },
])
it('should contain the "us" multi-region exactly once', () => {
const usRegions = VERTEX_REGIONS.filter((r: { value: string; label: string }) => r.value === "us")
expect(usRegions).toHaveLength(1)
expect(usRegions[0]).toEqual({ value: "us", label: "us" })
})

it('should contain the "eu" multi-region exactly once', () => {
const euRegions = VERTEX_REGIONS.filter((r: { value: string; label: string }) => r.value === "eu")
expect(euRegions).toHaveLength(1)
expect(euRegions[0]).toEqual({ value: "eu", label: "eu" })
})

it("should preserve existing regional endpoints", () => {
expect(VERTEX_REGIONS).toContainEqual({ value: "us-east5", label: "us-east5" })
expect(VERTEX_REGIONS).toContainEqual({ value: "europe-west1", label: "europe-west1" })
})

it('should contain "asia-east1" region exactly once', () => {
Expand Down
Loading