Skip to content

[Fix] Onboarding provider form starts above the viewport when user selects OpenAI Compatible #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edelauna merged 1 commit into from
May 15, 2026
Merged

[Fix] Onboarding provider form starts above the viewport when user selects OpenAI Compatible #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webview-ui/src/components/welcome/WelcomeViewProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const WelcomeViewProvider = () => {

return (
<Tab>
<TabContent className="flex flex-col gap-4 p-6 justify-center">
<TabContent className="flex flex-col gap-4 p-6">
<Brain className="size-8" strokeWidth={1.5} />
<h2 className="mt-0 mb-0 text-xl">{t("welcome:providerSignup.heading")}</h2>

Expand Down
19 changes: 18 additions & 1 deletion webview-ui/src/components/welcome/__tests__/WelcomeViewProvider.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@ vi.mock("../../settings/ApiOptions", () => ({
// Mock Tab components
vi.mock("../../common/Tab", () => ({
Tab: ({ children }: any) => <div data-testid="tab">{children}</div>,
TabContent: ({ children }: any) => <div data-testid="tab-content">{children}</div>,
TabContent: ({ children, className }: any) => (
<div data-testid="tab-content" className={className}>
{children}
</div>
),
}))

// Mock RooHero
Expand Down Expand Up @@ -133,6 +137,12 @@ describe("WelcomeViewProvider", () => {
expect(screen.getByTestId("trans-welcome:providerSignup.chooseProvider")).toBeInTheDocument()
})

it("keeps the landing screen centered", () => {
renderWelcomeViewProvider()

expect(screen.getByTestId("tab-content")).toHaveClass("justify-center")
})

it("does not enter auth-in-progress state after clicking 'Get Started' on landing", () => {
renderWelcomeViewProvider()

Expand Down Expand Up @@ -172,6 +182,13 @@ describe("WelcomeViewProvider", () => {
expect(screen.getByTestId("trans-welcome:providerSignup.chooseProvider")).toBeInTheDocument()
})

it("top-aligns provider setup content so tall forms remain reachable", () => {
renderWelcomeViewProvider()
navigateToProviderSelection()

expect(screen.getByTestId("tab-content")).not.toHaveClass("justify-center")
})

it("shows API options immediately", () => {
renderWelcomeViewProvider()
navigateToProviderSelection()
Expand Down
Loading