Skip to content

[Fix] Onboarding provider form starts above the viewport when user selects OpenAI Compatible#113

Merged
edelauna merged 1 commit into
mainfrom
fix/onboarding-provider-form-overflow-2f5x1ekwwh53i
May 15, 2026
Merged

[Fix] Onboarding provider form starts above the viewport when user selects OpenAI Compatible#113
edelauna merged 1 commit into
mainfrom
fix/onboarding-provider-form-overflow-2f5x1ekwwh53i

Conversation

@roomote

@roomote roomote Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Elliott de Launay. View the task or mention @roomote for follow-up asks.

What problem this solves

Fixes an issue where users choosing OpenAI Compatible during onboarding could land on a vertically centered provider form with the first required fields starting above the visible viewport.

Why this change was made

The welcome provider setup screen was using the same centered layout as the short landing state. That centering breaks down for taller provider forms, so the setup view now starts at the top of the scroll area while the landing screen stays centered.

User impact

Users selecting OpenAI Compatible during onboarding now immediately see the Base URL and API Key fields instead of needing to recover from a clipped form. The welcome screen also has regression coverage to keep the landing screen centered while the provider setup screen stays top-aligned.

Screenshots

OpenAI Compatible onboarding form stays top-aligned

OpenAI Compatible onboarding opens with the first configuration fields visible at scroll top.

@roomote roomote Bot added the roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR label May 15, 2026
@roomote

roomote Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

2 checks still pending after a 10-minute watch. See task

  • GitHub check still pending after a 10-minute watch: platform-unit-test (windows-latest)
  • GitHub check still pending after a 10-minute watch: platform-unit-test (ubuntu-latest)

@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@edelauna edelauna marked this pull request as ready for review May 15, 2026 01:05
@edelauna edelauna merged commit d87937b into main May 15, 2026
20 checks passed
@edelauna edelauna deleted the fix/onboarding-provider-form-overflow-2f5x1ekwwh53i branch May 27, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants