Skip to content

test(desktop): restore real-path smoke semantics#363

Merged
Whiteks1 merged 2 commits intomainfrom
codex/issue-275-real-path-validation
Apr 10, 2026
Merged

test(desktop): restore real-path smoke semantics#363
Whiteks1 merged 2 commits intomainfrom
codex/issue-275-real-path-validation

Conversation

@Whiteks1
Copy link
Copy Markdown
Owner

@Whiteks1 Whiteks1 commented Apr 10, 2026

Summary

  • parse explicit desktop smoke modes and pass them into Electron
  • keep fallback smoke isolated and tolerant while making real-path smoke require reachable research_ui
  • rename CI coverage to desktop-real-path and run the explicit real-path command

Issue

Why

  • the old smoke:real-path name implied a guarantee the desktop smoke did not actually enforce
  • maintainers need explicit separation between fallback shell coverage and real research_ui reachability
  • CI should fail when the live desktop path is broken instead of passing through local artifact fallback

Scope

This PR does not:

  • refactor renderer UX
  • change engine/core contracts
  • broaden desktop behavior beyond smoke semantics and CI naming

Validation

Validated with:

  • npm run smoke:fallback
  • npm run smoke:real-path
  • python -c "import yaml, pathlib; yaml.safe_load(pathlib.Path(r'.github/workflows/ci.yml').read_text(encoding='utf-8')); print('ci.yml parse ok')"

Duplication Check

  • I searched for an existing issue covering this slice.
  • I kept fallback and real-path smoke as separate semantics instead of overloading one command name.
  • I did not mix this branch with unrelated desktop UX or core changes.

Compatibility / Risk

  • fallback smoke remains available for tolerant shell/bootstrap coverage
  • real-path smoke now requires reachable research_ui, so CI becomes stricter by design
  • the main risk is CI/environment drift around desktop bootstrap, which is exactly the surface this slice is meant to expose

Notes

  • the branch was refreshed against current origin/main before merge review
  • fallback smoke now seeds its temporary runs index under the smoke output root instead of depending on real project outputs

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Whiteks1, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@Whiteks1 Whiteks1 merged commit d788a4f into main Apr 10, 2026
3 checks passed
@Whiteks1 Whiteks1 deleted the codex/issue-275-real-path-validation branch April 10, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

devops(desktop): restore real-path desktop validation and clarify smoke semantics

1 participant