refactor(desktop): establish TypeScript base across desktop#362
Merged
refactor(desktop): establish TypeScript base across desktop#362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
desktop/withtsconfig.json, global declarations, and atypecheckscript.main,preload, and the current renderer in JS while consumingdesktop/sharedcontracts natively.Issue
Why
mainor introducing the new renderer shell.Scope
This PR does not:
Validation
Validated with:
npm run typechecknode --check main.jsnode --check preload.jsnode --check renderer/app.jsnpm run smoke:fallbacknpm run smoke:real-pathDuplication Check
Compatibility / Risk
Notes
main, introduce React or Vite, or add new shared models beyond the existing contract foundation.main, including the already-merged real-path smoke semantics from test(desktop): restore real-path smoke semantics #363; this PR does not change smoke semantics itself.