Skip to content

refactor(desktop): establish TypeScript base across desktop#362

Merged
Whiteks1 merged 3 commits intomainfrom
codex/desktop-typescript-base
Apr 10, 2026
Merged

refactor(desktop): establish TypeScript base across desktop#362
Whiteks1 merged 3 commits intomainfrom
codex/desktop-typescript-base

Conversation

@Whiteks1
Copy link
Copy Markdown
Owner

@Whiteks1 Whiteks1 commented Apr 10, 2026

Summary

  • Add a real TypeScript base for desktop/ with tsconfig.json, global declarations, and a typecheck script.
  • Keep main, preload, and the current renderer in JS while consuming desktop/shared contracts natively.

Issue

Why

  • The desktop migration needed a real TypeScript base before modularizing main or introducing the new renderer shell.
  • This makes the shared contract layer consumable natively and reduces risk in the next architecture slices.

Scope

This PR does not:

  • Add unrelated feature work.
  • Expand scope beyond the slice.
  • Introduce a second source of truth for the same content or behavior.

Validation

Validated with:

  • npm run typecheck
  • node --check main.js
  • node --check preload.js
  • node --check renderer/app.js
  • npm run smoke:fallback
  • npm run smoke:real-path

Duplication Check

  • I searched for existing docs, surfaces, or contracts covering the same idea.
  • I removed or replaced stale copies instead of keeping both versions.
  • I did not introduce alternate lockfiles, package managers, or build paths.

Compatibility / Risk

  • No visible desktop behavior change intended; the slice is limited to TypeScript base wiring and narrow JS typing.
  • Main risk is typecheck friction in the existing renderer JS, contained here to minimum narrowing changes.

Notes

  • This PR intentionally does not modularize main, introduce React or Vite, or add new shared models beyond the existing contract foundation.
  • The branch has been refreshed onto current main, including the already-merged real-path smoke semantics from test(desktop): restore real-path smoke semantics #363; this PR does not change smoke semantics itself.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Whiteks1, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@Whiteks1 Whiteks1 merged commit 530fa06 into main Apr 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

desktop(architecture): establish TypeScript base across main, preload, shared, and renderer

1 participant