Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ultraplot/figure.py
Original file line number Diff line number Diff line change
Expand Up @@ -2322,18 +2322,23 @@ def _align_super_title(self, renderer):
ha = self._suptitle.get_ha()
va = self._suptitle.get_va()

# Use original centering algorithm for positioning (regardless of alignment)
# Use original centering algorithm for horizontal positioning.
x, _ = self._get_align_coord(
"top",
axs,
includepanels=self._includepanels,
align=ha,
)
y = self._get_offset_coord("top", axs, renderer, pad=pad, extra=labs)
y_target = self._get_offset_coord("top", axs, renderer, pad=pad, extra=labs)

# Set final position and alignment on the suptitle
# Place suptitle so its *bbox bottom* sits at the target offset.
# This preserves spacing for all vertical alignments (e.g. va='top').
self._suptitle.set_ha(ha)
self._suptitle.set_va(va)
self._suptitle.set_position((x, 0))
bbox = self._suptitle.get_window_extent(renderer)
y_bbox = self.transFigure.inverted().transform((0, bbox.ymin))[1]
y = y_target - y_bbox
self._suptitle.set_position((x, y))

def _update_axis_label(self, side, axs):
Expand Down
27 changes: 27 additions & 0 deletions ultraplot/tests/test_figure.py
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,33 @@ def test_suptitle_kw_position_reverted(ha, expectation):
uplt.close("all")


@pytest.mark.parametrize("va", ["bottom", "center", "top"])
def test_suptitle_vertical_alignment_preserves_top_spacing(va):
"""
Suptitle vertical alignment should not reduce the spacing above top content.
"""
fig, axs = uplt.subplots(ncols=2)
fig.format(
suptitle="Long figure title\nsecond line",
suptitle_kw={"va": va},
toplabels=("left", "right"),
)
fig.canvas.draw()
renderer = fig.canvas.get_renderer()

axs_top = fig._get_align_axes("top")
labs = tuple(t for t in fig._suplabel_dict["top"].values() if t.get_text())
pad = (fig._suptitle_pad / 72) / fig.get_size_inches()[1]
y_expected = fig._get_offset_coord("top", axs_top, renderer, pad=pad, extra=labs)

bbox = fig._suptitle.get_window_extent(renderer)
y_actual = fig.transFigure.inverted().transform((0, bbox.ymin))[1]
y_tol = 1.5 / (fig.dpi * fig.get_size_inches()[1]) # ~1.5 px tolerance
assert y_actual >= y_expected - y_tol

uplt.close("all")


def test_subplots_pixelsnap_aligns_axes_bounds():
with uplt.rc.context({"subplots.pixelsnap": True}):
fig, axs = uplt.subplots(ncols=2, nrows=2)
Expand Down
Loading