Fix suptitle top spacing for center/top vertical alignment#574
Merged
cvanelteren merged 1 commit intomainfrom Feb 9, 2026
Merged
Fix suptitle top spacing for center/top vertical alignment#574cvanelteren merged 1 commit intomainfrom
cvanelteren merged 1 commit intomainfrom
Conversation
Collaborator
Author
|
Still need to fix the regression of that one test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a suptitle layout regression where
suptitle_kwvertical alignments (va='center'orva='top') could let the suptitle overlap top content. The alignment code now computes the target top offset from surrounding content and then positions the suptitle so its bbox bottom lands at that offset, preserving spacing regardless of alignment. It also adds a regression test coveringva in {'bottom','center','top'}to enforce consistent top spacing. Closes #573.