Skip to content

TLS: Support certificates without common name (Fixes #749) #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Et0h wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TLS: Support certificates without common name (Fixes #749) #750

Et0h wants to merge 1 commit into from

Conversation

@Et0h
Copy link
Contributor

@Et0h Et0h commented Jan 21, 2026 •
edited
Loading

This hopefully fixes #749 but I've not tested it.

@Et0h Et0h mentioned this pull request Jan 21, 2026
Open
@Et0h Et0h requested a review from daniel-123 January 21, 2026 20:20
@SquirrelKiev
Copy link

SquirrelKiev commented Jan 22, 2026 •
edited
Loading

no dice, same issue as without the fix.
image
the above was from a different issue, PR works 🎉
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-123 daniel-123 Awaiting requested review from daniel-123

Assignees

@daniel-123 daniel-123

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support certificates using new lets encrypt profiles

4 participants

@Et0h @SquirrelKiev @daniel-123