Support certificates using new lets encrypt profiles

[SquirrelKiev]

LetsEncrypt's "new" certificate profiles no longer set Common Name (among doing other things). Certificates generated using these profiles aren't currently accepted by the Syncplay client. Any chance support for these could be added?

[Et0h]

Thanks for letting us know about this issue - I hadn't heard about this LetsEncrypt change or considered how it might impact Syncplay. I have now developed #750 to hopefully fix the issue but it still needs testing. Please test the new code with the new profile and let me know if it works.

[SquirrelKiev]

left a comment on the PR 👍

[daniel-123]

@SquirrelKiev thanks for reporting this, our official servers use Let's Encrypt certs and we would have been hit by this issue unaware in just few weeks otherwise. It's not yet clear to me why the validation fails since we delegate the verification to external library, but we'll certainly work on it.

Can you share either the hostname you are using or the actual Let's Encrypt profile you tested so that we can test with the same thing?

[SquirrelKiev]

Luckily I don't believe this will affect the official servers as the new profiles are opt-in (unless you have some other shenanigans going on I'm not aware of). The profiles in this case would be tlsserver and shortlived, should just be able to request them in your ACME client. Either way, I've thrown up a temporary test syncplay 1.7.4 server with a certificate using the tlsserver profile onto syncplay-cert-test.enonibobble.moe:8995.

Below is a sanity check using the same certificate on a web server, just to prove that the certificate is accepted by browsers.

[SquirrelKiev]

Worked out the issue with a friend who knows a lot more about this stuff than I do lmao, #751 + #750 fixes this