fix(control-plane): green the example validation (validator crash + schema contradiction + broken JSON)

[mdheller]

The control-plane contract check — surfaced via the "Validate OpsHistory contracts" CI job, which runs the whole make validate aggregate — has been red on main for ~2 months, independent of the cockpit contract pack (#195). This fixes it with a minimal, 4-file change.

Three distinct defects

1. Validator crash — tools/validate_control_plane_examples.py called Path.with_name("./release-set.schema.json"), which raises ValueError (with_name rejects names containing /). The correct (schema_path.parent / legacy_ref).resolve() already sat on the next line; removed the dead/crashing one.

2. Contradictory schemas for one example (the core breakage). examples/release_set.json and examples/fingerprint.json are validated by both validators:

   • validate-control-plane-examples → the control-plane wrappers, which allOf-delegated to the legacy snake_case schemas (release_set_id, created_at, …)
   • validate-nlboot-examples → the canonical v2 camelCase schemas (id/type/specVersion, createdAt, …)

   Both are additionalProperties: false with mutually exclusive key sets, so no single document can satisfy both — unfixable at the example level. Repointed the two shared wrappers (schemas/control-plane/ReleaseSet.json, Fingerprint.json) to delegate to the canonical v2 contracts (../ReleaseSet.json, ../Fingerprint.json) — matching the wrappers' stated purpose of "providing a stable srcos namespace." BootReleaseSet/EnrollmentToken keep their legacy snake schemas (only the control-plane validator checks them; no v2 equivalent).

3. Invalid JSON — examples/boot_release_set.json was a botched merge (from a2b9dc9 into work/boot-provisioning-examples): two object bodies concatenated (missing comma after the first block's notes, duplicate status/artifacts/created_at/notes). Reconstructed as the single valid union its rich schema requires (identity fields + the fuller recovery body).

Result

make validate now passes end-to-end — control-plane, nlboot, and all other families:

OK: validate

Note: this is the control-plane / boot-provisioning lane. The boot JSON repair reconstructs the intended union of that workstream's merge; worth a glance from its owner to confirm the reconstructed boot_release_set.json matches intent.

🤖 Generated with Claude Code