fix(ci): repair the Validate Spec workflow + complete the CompressionEvaluation schema#197
Merged
Merged
Conversation
…Evaluation schema
Two coupled fixes that green the last dark workflow on main:
1. .github/workflows/validate.yml failed in 0s on EVERY commit for weeks
('workflow file issue') because two step 'name:' values contained an
unquoted colon ('Guardrail: detect ...'), which YAML parses as a nested
mapping — GitHub rejected the whole file. Quoted both names.
2. Un-breaking the workflow makes its dormant jobs run, which unmasked one
content failure: examples/compressionevaluation.json carried fields absent
from schemas/CompressionEvaluation.json (additionalProperties:false):
truthSurfaceRef, deltaSurfaceRef, integrity{evaluationHash,signer,signature,
signedAt}, notes, plus metrics.supportingMetrics + metrics.normalizationVersion.
These are intentional (surface refs + signed integrity envelope), so added
them to the schema as optional — additive, non-breaking.
Verified locally: validate.yml parses; all 263 top-level schemas compile under
ajv; both guardrail scripts pass; by-type example validation 170 pass / 0 fail;
openapi/asyncapi/jsonld parse; make validate green end-to-end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greens the last dark workflow on
main. Companion to #196 (which fixed the OpsHistory/make validatecheck).Two coupled fixes
.github/workflows/validate.ymlfailed in 0s on every commit for weeks ("This run likely failed because of a workflow file issue") — invalid YAML: two stepname:values contained an unquoted colon (Guardrail: detect duplicate schema $id values), which YAML parses as a nested mapping, so GitHub rejected the whole file. Quoted both names.yaml.safe_loadnow parses clean.Un-breaking the workflow makes its dormant jobs run, which unmasked one content failure:
examples/compressionevaluation.jsoncarried fields absent fromschemas/CompressionEvaluation.json(which isadditionalProperties: false):truthSurfaceRef,deltaSurfaceRef,integrity(evaluationHash/signer/signature/signedAt),notes, plusmetrics.supportingMetricsandmetrics.normalizationVersion. These are intentional (surface refs + a signed integrity envelope), so I added them to the schema as optional properties — additive, non-breaking.Verified locally (all
validate.ymljobs)validate.ymlparses; no other unquoted-colonname:in.github/workflows/ajv(the exact workflow loop) — no latent failurescheck_duplicate_schema_ids.py,validate_control_plane_wrapper_ids.py)openapi.yaml/asyncapi.yaml/semantic/*.jsonldall parsemake validategreen end-to-endAfter this,
mainis green across every workflow.🤖 Generated with Claude Code