Skip to content

fix: Command injection in contract check workflow #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrwind-up-bird wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: Command injection in contract check workflow #161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a75ae1b
Merge pull request #129 from SimplyLiz/develop
SimplyLiz Feb 1, 2026
8698e75
fix(autofix): Command injection in contract check workflow
mrwind-up-bird Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/github-actions/contract-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
id: contracts
run: |
CONTRACTS=$(git diff --name-only ${{ github.event.pull_request.base.sha }}..${{ github.sha }} \
| grep -E '\.(proto|yaml|json)$' \
CONTRACTS=$(git diff --name-only "${{ github.event.pull_request.base.sha }}..${{ github.sha }}" \
| grep -E '(proto/|openapi/|api/|swagger)' || true)

if [ -n "$CONTRACTS" ]; then
Expand All @@ -67,7 +67,7 @@ jobs:
## Contract Change Analysis

This PR modifies API contract files. Cross-boundary impact analysis:

echo "Analyzing: $(printf '%q' "$CONTRACT")"
EOF

while IFS= read -r CONTRACT; do
Expand All @@ -76,7 +76,7 @@ jobs:
RESULT=$(curl -s "http://localhost:8080/contracts/impact?path=$CONTRACT" || echo '{}')

VISIBILITY=$(echo "$RESULT" | jq -r '.visibility // "unknown"')
CONSUMERS=$(echo "$RESULT" | jq -r '.consumers | length // 0')
echo "### \`$(printf '%q' "$CONTRACT")\`" >> contract-report.md
RISK=$(echo "$RESULT" | jq -r '.riskLevel // "unknown"')

echo "" >> contract-report.md
Expand Down
Loading