fix: Command injection in contract check workflow#161
Open
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Open
fix: Command injection in contract check workflow#161mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
mrwind-up-bird wants to merge 2 commits intoSimplyLiz:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #161 +/- ##
=========================================
+ Coverage 45.1% 45.6% +0.5%
=========================================
Files 350 367 +17
Lines 59747 61934 +2187
=========================================
+ Hits 26961 28274 +1313
- Misses 30960 31744 +784
- Partials 1826 1916 +90
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Command injection in contract check workflow
Category: security
Severity: high
Issue
Contract file paths are directly interpolated into shell commands without sanitization, allowing path traversal and command injection via malicious file names.
Fix
The fix addresses command injection vulnerabilities by: 1) Quoting the git diff range parameter to prevent shell injection via commit hashes, 2) Using printf '%q' to safely escape file paths when echoing them to logs and reports, preventing path traversal and command injection via malicious filenames. The changes maintain the existing functionality while preventing shell metacharacters from being interpreted.
Generated by nyxCore AutoFix