Use SciMLTesting v1.2 (folder-based run_tests)#464
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Convert ModelingToolkitStandardLibrary.jl to the SciMLTesting v1.2
folder-discovery model. runtests.jl becomes `using SciMLTesting;
run_tests()`.
Layout:
- Core: the functional test files are flattened from their domain
subfolders (Blocks/, Electrical/, Thermal/, Magnetic/, Mechanical/,
Hydraulic/) to the top level of test/, which is the Core group in the
folder model. Folder-discovery does not recurse into subfolders, so
Core must live at the top level. Basenames do not collide.
- QA: test/aqua.jl moves to test/qa/aqua.jl. QA runs in the main test
env (Aqua is in the root [extras]); no test/qa/Project.toml is added.
- test/Mechanical/multibody.jl moves to test/shared/ because it is
present on disk but is NOT run by the old runtests.jl (it depends on
CairoMakie). test/shared/ is not a declared group, so it is never
discovered, preserving that exclusion.
Per-GROUP behavior is preserved exactly: GROUP=Core runs the same 19
functional files as before (multibody excluded); GROUP=QA runs Aqua.
SciMLTesting added to [extras], [targets].test, and [compat] ("1").
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
89fbbcb to
8dc93f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert ModelingToolkitStandardLibrary.jl to the SciMLTesting v1.2 folder-discovery model.
test/runtests.jlbecomesusing SciMLTesting; run_tests().Layout:
Blocks/,Electrical/,Thermal/,Magnetic/,Mechanical/,Hydraulic/) to the top level oftest/, which is the Core group in the folder model. Folder-discovery does not recurse into subfolders, so Core lives at the top level. Basenames do not collide.test/aqua.jlmoves totest/qa/aqua.jl. QA runs in the main test env (Aqua is in the root[extras]); notest/qa/Project.tomlis added.test/Mechanical/multibody.jlmoves totest/shared/because it is present on disk but is NOT run by the oldruntests.jl(it depends on CairoMakie).test/shared/is not a declared group, so it is never discovered, preserving that exclusion.SciMLTestingadded to[extras],[targets].test, and[compat](= "1").test/test_groups.tomlis unchanged ([Core],[QA]).Per-GROUP behavior preserved exactly, verified by driving
run_testsv1.2.0 overGROUP=Core/QA/Allwith stub bodies:GROUP=Corefires exactly the 19 functional files (multibody excluded), matching the old dispatcher.GROUP=QAfires Aqua.These are the GROUP values CI uses (grouped-tests.yml runs Core + QA; downgrade.yml runs Core).
Ignore until reviewed by @ChrisRackauckas.