Use InitializationProblem() in the SISO tests (rebase of #465)#469
Merged
Merged
Conversation
This would otherwise throw errors from constructing NonlinearProblem directly, because a NonlinearProblem requires a square system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #465 by @JamesWrigley onto current
main.#465 became conflicting only because the test layout was restructured upstream (
test/Blocks/utils.jl→test/utils.jlvia #463/#464); there is no real content conflict. The change replaces the manualgenerate_initializesystem+mtkcompile+NonlinearProblemsequence withModelingToolkit.InitializationProblem(sys, 0.0)in the SISO tests. Git followed the rename and applied it cleanly on top of release v2.29.1.Supersedes #465 (which can be closed once this is reviewed). Original authorship preserved on the commit.