Skip to content

add setting to toggle joining vc on room click #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RasmusAntons wants to merge 1 commit into
base: dev
Choose a base branch
from
+29 −2

add setting to toggle joining vc on room click

424212b
Select commit
Loading
Failed to load commit list.
Open

add setting to toggle joining vc on room click #102

add setting to toggle joining vc on room click
424212b
Select commit
Loading
Failed to load commit list.
Knope Bot / Require changes to be documented required action Mar 9, 2026 in 0s

This pull request has not been documented yet

This project requires changes to be documented via changesets.

You can either correct the above issues, or use a change file to document this pull request. knope-bot can't auto-generate a change file for this pull request. Instead, you can document the change manually by creating a change file with Knope or following these instructions:

Alternatively, if this change doesn't affect the version or need to appear in the changelog, you can apply the internal label to skip this check.

  1. Create a file named .changeset/add_setting_to_toggle_joining_vc_on_room_click.md
  2. Copy and paste the below Markdown into the file
  3. Replace "CHANGE_TYPE" with major, minor, or patch (see knope's docs for what those mean)
  4. Edit the content as needed to be applicable to users of the project (not maintainers)

Details

---
sable: CHANGE_TYPE
---

# add setting to toggle joining vc on room click

#102 by @RasmusAntons

### Description

I added one setting that lets the user disable the behavior of immediately joining a voice call when clicking the NavButton. I personally am stupid and will accidentally join a voice sometimes call which is very embarrassing.

I'm not sure if the settings hierarchy is what you have in mind, if not feel free to make changes or close this PR and implement something like this yourselves. 

#### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
View more details on Knope Bot