Skip to content

add setting to toggle joining vc on room click#102

Open
RasmusAntons wants to merge 1 commit intoSableClient:devfrom
RasmusAntons:join-voice-immediately-setting
Open

add setting to toggle joining vc on room click#102
RasmusAntons wants to merge 1 commit intoSableClient:devfrom
RasmusAntons:join-voice-immediately-setting

Conversation

@RasmusAntons
Copy link

Description

I added one setting that lets the user disable the behavior of immediately joining a voice call when clicking the NavButton. I personally am stupid and will accidentally join a voice sometimes call which is very embarrassing.

I'm not sure if the settings hierarchy is what you have in mind, if not feel free to make changes or close this PR and implement something like this yourselves.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@RasmusAntons RasmusAntons requested a review from a team March 9, 2026 21:06
@hazre
Copy link
Contributor

hazre commented Mar 10, 2026

What if it required double clicking the room to join it instead, would that solve your problem? Double clicking within a period joins room, otherwise it shows the prescreening view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants