add setting to toggle joining vc on room click#102
Open
RasmusAntons wants to merge 1 commit intoSableClient:devfrom
Open
add setting to toggle joining vc on room click#102RasmusAntons wants to merge 1 commit intoSableClient:devfrom
RasmusAntons wants to merge 1 commit intoSableClient:devfrom
Conversation
Contributor
|
What if it required double clicking the room to join it instead, would that solve your problem? Double clicking within a period joins room, otherwise it shows the prescreening view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added one setting that lets the user disable the behavior of immediately joining a voice call when clicking the NavButton. I personally am stupid and will accidentally join a voice sometimes call which is very embarrassing.
I'm not sure if the settings hierarchy is what you have in mind, if not feel free to make changes or close this PR and implement something like this yourselves.
Type of change
Checklist: