refactor(DAO-2005): migrate btc-vault formatters to shared utilities [2/5]#2101
Open
Freshenext wants to merge 3 commits intomainfrom
Open
refactor(DAO-2005): migrate btc-vault formatters to shared utilities [2/5]#2101Freshenext wants to merge 3 commits intomainfrom
Freshenext wants to merge 3 commits intomainfrom
Conversation
…ion, and date Introduce three shared formatting modules in lib/utils: - formatPercentage: rewritten to produce "10.20%" (padded + suffix, no range validation) - formatDuration: configurable time-unit formatter with leading-zero suppression - formatDate: 10 Luxon-based date formatters replacing scattered Intl/moment implementations Also updates durationToLabel to delegate to the new formatDuration.
- Remove formatPercent, date functions from btc-vault formatters.ts - Update mappers.ts to import formatPercentage, formatDateDayFirst, formatDateMonthFirst from @/lib/utils - Update BtcVaultMetrics to use formatDateFullMonth and formatDateMonthFirst from @/lib/utils
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
cybervoid0
approved these changes
Apr 14, 2026
Contributor
|
check the failing test please |
Missed imports of formatDateMonthFirst and formatDateFullMonthPaddedDayUtc still pointed at the btc-vault formatters after they were removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatPercentand all date functions from btc-vaultformatters.tsmappers.tsto importformatPercentage,formatDateDayFirst,formatDateMonthFirstfrom@/lib/utilsBtcVaultMetricsto useformatDateFullMonthandformatDateMonthFirstfrom shared utils