refactor(DAO-2005): consolidate staking, vault, proposal formatters and remove moment from Countdown [5/5]#2104
Open
Freshenext wants to merge 1 commit intoDAO-2005-4-my-rewardsfrom
Open
refactor(DAO-2005): consolidate staking, vault, proposal formatters and remove moment from Countdown [5/5]#2104Freshenext wants to merge 1 commit intoDAO-2005-4-my-rewardsfrom
Freshenext wants to merge 1 commit intoDAO-2005-4-my-rewardsfrom
Conversation
…nd remove moment from Countdown - Remove duplicate formatPeriod from vault/history, staking-history, and staking CSV; replace with shared formatPeriodToMonthYear - Replace formatExpandedDate imports with shared formatDateExpanded - Staking CSV route delegates to shared formatDateForCsv with UTC/24h options - proposals/shared/utils delegates formatTimestampToMonthYear to shared formatMonthYear - Countdown component uses formatDuration instead of moment.duration
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatPeriodfunctions; replace with sharedformatPeriodToMonthYearformatExpandedDateimports with sharedformatDateExpandedin vault/history and staking-historyformatDateForCsvwith UTC/24h optionsformatTimestampToMonthYearin proposals delegates to sharedformatMonthYearCountdowncomponent usesformatDurationinstead ofmoment.duration, removing the moment.js dependency