Fix weekly view buttons and add ISO week format docs#512
Fix weekly view buttons and add ISO week format docs#512salmonumbrella wants to merge 1 commit intoRoamJS:mainfrom
Conversation
|
Warning Rate limit exceeded@salmonumbrella has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 32 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Changes
Issue #494 - Weekly View buttons intermittent display
Root cause: The original implementation used
setTimeoutwith 0ms delay after hashchange, but the h1 element may not exist in the DOM yet on some page transitions.Fix: Moved the button rendering logic into the existing
h1Observercallback which usescreateHTMLObserverto reliably detect when h1 elements with classrm-title-displayappear. This ensures buttons are always rendered when the header is available.Issue #409 - ISO week format support
Added documentation for ISO week-numbering tokens that are already supported:
I/II- ISO week numberR/RRRR- ISO week-numbering yearExamples like
{monday:RRRR}-W{monday:II}→[[2024-W52]]now documented.Test plan
{monday:RRRR}-W{monday:II}