feat(display):implement automatic reconnection for ROS and Video streams #713
Merged
CamilaTite26 merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
GilMM27
reviewed
Mar 4, 2026
Contributor
There was a problem hiding this comment.
could you explain why we need to modify this component?
Contributor
Author
There was a problem hiding this comment.
It is to implement an automatic reconnection of the stream.
GilMM27
reviewed
Mar 4, 2026
| return ( | ||
| <div className="w-full max-w-3xl"> | ||
| <img | ||
| key={retryCount} |
Contributor
Author
There was a problem hiding this comment.
Yes, the key forces React to restart the img component from scratch.
Contributor
|
please upload a video of the reconnection ;) |
Contributor
Author
Screencast.from.03-07-2026.11.50.17.AM.webm |
Contributor
|
please address my comments |
JLDominguezM
pushed a commit
that referenced
this pull request
Mar 18, 2026
JLDominguezM
pushed a commit
that referenced
this pull request
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implement auto-reconnect for ROS and video stream