Skip to content

rocprofv3-avail minor scrip fix#120

Closed
rocm-devops wants to merge 3 commits into
amd-stagingfrom
gobhardw/rocprofv3-avail-minor-fix
Closed

rocprofv3-avail minor scrip fix#120
rocm-devops wants to merge 3 commits into
amd-stagingfrom
gobhardw/rocprofv3-avail-minor-fix

Conversation

@rocm-devops

Copy link
Copy Markdown

PR Details

Associated Jira Ticket Number/Link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Continuous Integration

Technical details

While preparing for a presentation, I discovered rocprofv3-avail doesn't handle a condition where no arguments are provided to the script. IMO it should be handled the same way as rocprofv3 script.

Added/updated tests?

  • Yes
  • No, Does not apply to this PR.

Updated CHANGELOG?

  • Yes
  • No, Does not apply to this PR.

Added/Updated documentation?

  • Yes
  • No, Does not apply to this PR.

@rocm-devops

Copy link
Copy Markdown
Author

Code Coverage Report

Code Coverage Report

Tests Only

code coverage tests.png

Samples Only

code coverage samples.png

Tests + Samples

code coverage all.png

@jayhawk-commits

Copy link
Copy Markdown
Contributor

Imported to ROCm/rocm-systems.

@amd-hsivasun amd-hsivasun added ready for peer review PR needs initial review bug fix labels Aug 7, 2025
ammallya pushed a commit that referenced this pull request Oct 28, 2025
* Small debug print fix in ioctl.cpp

Fix debug print statement to print agent id.

* formatting

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 71dc203]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix ready for peer review PR needs initial review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants