rocprofv3-avail minor scrip fix#172
Merged
bwelton merged 4 commits intoSep 2, 2025
Merged
Conversation
systems-assistant
Bot
requested review from
SrirakshaNag and
bgopesh
as code owners
ammallya
pushed a commit
that referenced
this pull request
Aug 7, 2025
* adding codeql.yml * update codeql * update codeql * excluding external repos * filter external * filter external and build * Apply suggestions from code review * Removed experimental test line * Adding config * moving codeql config out of workflows * Disable Cdash * update codeql * replacing run-ci with simple cmake build * cmake fix * removing codeql_config * Adding rule for python and actions --------- Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com> [ROCm/rocprofiler-sdk commit: 215875d]
ywang103-amd
pushed a commit
to ywang103-amd/rocm-systems
that referenced
this pull request
Aug 7, 2025
[ROCm/rocprofiler-systems commit: f03dce5]
systems-assistant Bot
pushed a commit
that referenced
this pull request
Aug 10, 2025
* Update vector types test * update MakeVector to be host+device function * Add regression testing * Add tests for subscript operator Change-Id: Ifac85aaa6cd6d6bd96c4239414e38f284e2a2d54 * Fix unused vars Change-Id: I6bc2da76dbf962db5d75ea5a84bf16b66f8ba6ba --------- Co-authored-by: Aidan Belton <abeltons@amd.com>
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
* Update vector types test * update MakeVector to be host+device function * Add regression testing * Add tests for subscript operator Change-Id: Ifac85aaa6cd6d6bd96c4239414e38f284e2a2d54 * Fix unused vars Change-Id: I6bc2da76dbf962db5d75ea5a84bf16b66f8ba6ba --------- Co-authored-by: Aidan Belton <abeltons@amd.com> [ROCm/hip-tests commit: ef6c95f]
jrmadsen
requested changes
Aug 26, 2025
Comment on lines
+461
to
+465
| if argv is None or len(argv) == 0: | ||
| avail.fatal_error("No arguments provided") | ||
|
|
Contributor
There was a problem hiding this comment.
Make it display help menu
bgopesh
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/gobhardw_rocprofv3-avail-minor-fix
branch
from
971f87e to
e6230d6
Compare
bwelton
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/gobhardw_rocprofv3-avail-minor-fix
branch
from
e6230d6 to
063991a
Compare
bwelton
approved these changes
Sep 2, 2025
Collaborator
|
bwelton
deleted the
import/develop/ROCm_rocprofiler-sdk/gobhardw_rocprofv3-avail-minor-fix
branch
systems-assistant Bot
pushed a commit
to ROCm/rocprofiler-sdk
that referenced
this pull request
Sep 2, 2025
* rocprofv3-avail scrip fix * addressing feedback * formatting * rocprofv3 and rocprofv3-avail to display help when no args are provided [rocm-systems] ROCm/rocm-systems#172 (commit 45e969f)
ammallya
pushed a commit
that referenced
this pull request
Jan 30, 2026
ammallya
pushed a commit
that referenced
this pull request
Jan 30, 2026
[ROCm/rocjpeg commit: c3d5e4f]
ammallya
pushed a commit
that referenced
this pull request
Apr 9, 2026
…172) ## Motivation The ROCm build process sets certain build variables in the environment from a build orchestrator. These arguments are not strictly necessary for packaging; however, they are used to set a unified filename structure across all ROCm packages for a given release. These are not required though for building. `rocm-cmake` will only accept them through the environment and does not expose a way to provide them directly as a CMake function parameter. This PR also sets which version of ROCm we are building against rather than just blindly using whatever the `/opt/rocm` symlink refers to. Should neither the ROCm Version or ROCm Path be set at configure time, we fallback to the `/opt/rocm` symlink and try to ascertain what version of ROCm is present. We can then take this a step further by letting the CI control what version of ROCm we want to target, which gets passed into the DOCKERFILE to construct a CI image for a given platform with the target ROCm version installed. A default ROCm version is still specified in the DOCKERFILE's for convenience if someone is trying to build locally. ## Technical Details Investigating other project's CMakeLists.txt and setupenv.sh in rocm-build. ## Test Plan Does CI pass? Does the hipFile build artifacts filename structure now match what ROCm releases? Does hipFile still build locally without specifying any of the new arguments/environment variables? ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. AIHIPFILE-97
ammallya
pushed a commit
that referenced
this pull request
Apr 9, 2026
## Motivation Enable the hipFile CI to run in a forked GitHub repository by default without needing to manually patch the workflow to use a different GHCR URL. ## Technical Details This changes the GHCR URL that is used to pull the CI images. Originally it was fixed to the main hipFile repository. Now, the URL will set itself to the GHCR registry space of the repository the workflow is being operated on. Please note, that forked PRs targeting ROCm/hipFile will use the ROCm/hipFile image registry. As such, even with this change, forked PRs modifying the DOCKERFILE's are not supported. ## Test Plan Verify there is no impact to CI in the hipFile repo. Check that non-PR triggered workflows in the forked repo work as expected. CI workflows on forked repo's that run on GitHub hosted runners should pass as expected. Workflows requiring self-hosted machines should not expect to be started (unless a forked repo has setup an appropriate self-hosted runner). ## Test Result Run on personal fork: https://github.com/riley-dixon/hipFile-test/actions/runs/21407607892?pr=16 (Note: The run did include other changes in #172) Update CI images success: https://github.com/riley-dixon/hipFile-test/actions/runs/21412596990 Manually triggered nightly release: https://github.com/riley-dixon/hipFile-test/actions/runs/21414023786 Scheduled release job: https://github.com/riley-dixon/hipFile-test/actions/runs/21414357640 ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
ammallya
pushed a commit
that referenced
this pull request
Apr 9, 2026
…172) ## Motivation The ROCm build process sets certain build variables in the environment from a build orchestrator. These arguments are not strictly necessary for packaging; however, they are used to set a unified filename structure across all ROCm packages for a given release. These are not required though for building. `rocm-cmake` will only accept them through the environment and does not expose a way to provide them directly as a CMake function parameter. This PR also sets which version of ROCm we are building against rather than just blindly using whatever the `/opt/rocm` symlink refers to. Should neither the ROCm Version or ROCm Path be set at configure time, we fallback to the `/opt/rocm` symlink and try to ascertain what version of ROCm is present. We can then take this a step further by letting the CI control what version of ROCm we want to target, which gets passed into the DOCKERFILE to construct a CI image for a given platform with the target ROCm version installed. A default ROCm version is still specified in the DOCKERFILE's for convenience if someone is trying to build locally. ## Technical Details Investigating other project's CMakeLists.txt and setupenv.sh in rocm-build. ## Test Plan Does CI pass? Does the hipFile build artifacts filename structure now match what ROCm releases? Does hipFile still build locally without specifying any of the new arguments/environment variables? ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. AIHIPFILE-97 [ROCm/hipFile commit: f954027]
ammallya
pushed a commit
that referenced
this pull request
Apr 9, 2026
## Motivation Enable the hipFile CI to run in a forked GitHub repository by default without needing to manually patch the workflow to use a different GHCR URL. ## Technical Details This changes the GHCR URL that is used to pull the CI images. Originally it was fixed to the main hipFile repository. Now, the URL will set itself to the GHCR registry space of the repository the workflow is being operated on. Please note, that forked PRs targeting ROCm/hipFile will use the ROCm/hipFile image registry. As such, even with this change, forked PRs modifying the DOCKERFILE's are not supported. ## Test Plan Verify there is no impact to CI in the hipFile repo. Check that non-PR triggered workflows in the forked repo work as expected. CI workflows on forked repo's that run on GitHub hosted runners should pass as expected. Workflows requiring self-hosted machines should not expect to be started (unless a forked repo has setup an appropriate self-hosted runner). ## Test Result Run on personal fork: https://github.com/riley-dixon/hipFile-test/actions/runs/21407607892?pr=16 (Note: The run did include other changes in #172) Update CI images success: https://github.com/riley-dixon/hipFile-test/actions/runs/21412596990 Manually triggered nightly release: https://github.com/riley-dixon/hipFile-test/actions/runs/21414023786 Scheduled release job: https://github.com/riley-dixon/hipFile-test/actions/runs/21414357640 ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. [ROCm/hipFile commit: 5ba2f18]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Associated Jira Ticket Number/Link
What type of PR is this? (check all applicable)
Technical details
While preparing for a presentation, I discovered rocprofv3-avail doesn't handle a condition where no arguments are provided to the script. With this patch,
rocprofv3androcprofv3-availdisplayshelpmenu if no other arguments are provided.Added/updated tests?
Updated CHANGELOG?
Added/Updated documentation?
🔁 Imported from ROCm/rocprofiler-sdk#120
🧑💻 Originally authored by @rocm-devops