[rocpd] CSV python writer#102
Closed
rocm-devops wants to merge 23 commits into
Closed
Conversation
Author
|
Can you also incorporate the fixes from https://github.com/AMD-ROCm-Internal/rocprofiler-sdk-internal/pull/497/files#diff-7d52ebbe190c96f678b06cb7993edfd2b2fc6ba230882462ed8a31ded64f8102 in your refactored change? |
Author
|
Author
|
To format your python code to pass linting, make sure you
|
Author
|
Araceli's PR also had some tests she added. It would be nice to bring them in with your CSV refactoring. It was a more comprehensive test which actually compares the CSV headers against the JSON. https://github.com/AMD-ROCm-Internal/rocprofiler-sdk-internal/pull/519 |
12 tasks
Contributor
|
Imported to ROCm/rocm-systems. |
12 tasks
12 tasks
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
* Update LICENSE * Update conf.py * Update copyright year * [fix] Update copyright year * Update copyright year "ROCm Developer Tools" * Add license headers to c++ files * Add license to *.py * Update licenses in rocdecode sources --------- Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com> Co-authored-by: Mythreya <mythreya.kuricheti@amd.com> Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com> [ROCm/rocprofiler-sdk commit: 97b7a63]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Associated Jira Ticket Number/Link
https://ontrack-internal.amd.com/browse/SWDEV-543953
What type of PR is this? (check all applicable)
Technical details
Added/updated tests?
Updated CHANGELOG?
Added/Updated documentation?